-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"There is no value in the ParticipantDevice enum that corresponds to 'win 11'." #354
Comments
We have seen this problem before (here, here and here). The issue is that Zoom, from time to time, adds new values to the "participant device" enum without documenting these changes which causes the ZoomNet library to fail when attempting to parse the undocumented value. The new value you just discovered (which is Anyway, long story short: the solution is to add this new value to the list of possible value that represent a Windows based device in the ZoomNet library so that our participant device converter knows how to deal with this value. I was already planning a new release in the next few days, so this issue should be fixed shortly. |
Thank you for clarifying it. I forked the branch and added win 11 to the enum list then discovered next device value which is just a number. I ended up removing the throw statement in line 801 in Internal.cs and just return default(T). That bypassed the issue for me.
|
Can you please elaborate what you mean? Are you saying Zoom returned a number instead of a string such as "windows"? Can you share the JSON payload you receive from the APIso I can reproduce your scenario? |
Besides "win 11", it also has "win 10" and if handled both, it fails on "17763" Looking at the raw json response, it looks like because device is "win 10+ 17763" {
"id":"MercKjkyQMCa3eTEXYeObQ",
"user_id":"16778240",
"participant_uuid":"1B2551FE-F292-3F4D-756B-1300A102125C",
"user_name":"iL9",
"device":"win 10+ 17763",
"ip_address":"31.44.5.60",
"internal_ip_addresses":["31.44.*.*"],
"location":"(US)",
"network_type":"Wired",
"data_center":"Netherlands (AMS Top)",
"full_data_center":"Netherlands (AMS Top);",
"connection_type":"Reliable UDP",
"join_time":"2024-07-22T20:42:06Z",
"share_application":false,
"share_desktop":false,
"share_whiteboard":false,
"recording":false,
"pc_name":"AX-VHOST03",
"domain":"",
"mac_addr":"ca02-bf82-a61a",
"harddisk_id":"VirtIO:BHYVE-CEBF-C97F-EA99;",
"version":"6.0.11.39959",
"email":"[email protected]",
"registrant_id":"",
"status":"in_meeting",
"os":"win",
"os_version":"\\"10+ 17763\\"",
"device_name":"",
"groupId":"",
"customer_key":"",
"sip_uri":"",
"from_sip_uri":"",
"role":"host",
"participant_user_id":"MercKjkyQMCa3eTEXYeObQ",
"audio_call":[]
} |
Do you know what 17763 represents? |
17763 seems to be a windows 10 build number. Full device name "win 10+ 17763" I think the + messed up the parsing somehow so it tries to read win 10 and 17763 as 2 separate device names |
Looks like you're right, 17763 is indeed a build number for windows 10. What this tells me is that sometimes the '+' symbol is used as a delimiter between two distinct values like this example: However, in the scenario that you are bringing to my attention today, the '+' symbol is used for a different purpose. It's used to separate the enum value representing a device ("win 11" in your example) and the OS build number. So, not only do I need to add "win 10" and "win 11" to the DeviceParticipant enum, I also must improve the ParticipantDeviceConverter to be able to handle OS build numbers. |
What's even more confusing is there are two new nodes in the JSON you provided (thanks for that by the way). The os and os_version node are new (to me anyway), I'll make sure to add them to our Participant model class. |
I'm preparing to release 0.79.0 which will include this enhancement. |
🎉 This issue has been resolved in version 0.79.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Used to work just fine, today it started failing with following stack trace. Look like ParticipantDeviceConverter is missing the the handling of device: win 11. Is there any quick workaround?
Originally posted by @cropter123 in #353
The text was updated successfully, but these errors were encountered: