Issue: The DownloadFileAsync method will throw an OutOfMemoryException if the file is too large #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2024 17:37
…he recording file stream
Jericho
requested changes
Apr 19, 2024
| @@ -372,6 +367,25 @@ public Task<Stream> DownloadFileAsync(string downloadUrl, CancellationToken canc | |||
| .AsStream(); | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public async Task<Stream> DownloadFileWithouBufferingAsync(string downloadUrl, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
Can you think of a downside to downloading a file without buffering? I can't think of one. Which leads me to think that all files, large or small, should probably be downloaded without buffering. Which means there's no need for a separate DownloadFileWithouBufferingAsync method and you can move the logic to the DownloadFileAsync method.
There was a problem hiding this comment.
From this point of view, then you are right =)
I have removed the method separating.
Jericho
approved these changes
Apr 22, 2024
|
🎉 This issue has been resolved in version 0.76.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue when we use the DownloadFileAsync method. Since it uses IRequest.AsStream(), this method invokes HttpClient.SendAsync(request, cancellationtoken) and than HttpResponseMessage.Content.ReadAsStreamAsync() for the response message.
The HttpResponseMessage.Content.ReadAsStreamAsync() read whole content into the memory buffer and makes the stream from result buffer.
In our project we encountered with following issue: if we receive a large enough file, buffer can overflow.
But I also found (here Streaming Large HTTP Responses) if we call HttpClient.SendAsync with HttpCompletionOption.ResponseHeadersRead flag it just return stream without buffering and we can handle received stream as we want.
So I suggest to use old implementation of DownloadFileAsync in new method, but with HttpCompletionOption.ResponseHeadersRead flag.
May we also need to create issue in Pathoschild repository.