-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧨 (revamp) NICE-43 Next RSC, Notion API, & Tailwind [b] [!] #1621
Conversation
51b4aae
to
02ea005
Compare
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621 👷 (github) NICE-43 turn off `e2e` at the moment
|
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621 👷 (github) NICE-43 turn off `e2e` at the moment 👷 (vercel) NICE-43 vercel.json; + required env next-config 👷 (github) NICE-43 put e2e back w/ env populated
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621 👷 (github) NICE-43 turn off `e2e` at the moment 👷 (vercel) NICE-43 vercel.json; + required env next-config 👷 (github) NICE-43 put e2e back w/ env populated 👷 (github) NICE-43 pass env to actions
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621 👷 (github) NICE-43 turn off `e2e` at the moment 👷 (vercel) NICE-43 vercel.json; + required env next-config 👷 (github) NICE-43 put e2e back w/ env populated 👷 (github) NICE-43 pass env to actions ♿️ (radix-ui) NICE-43 color-contrast for tags (gray) 🔧 (lhci) NICE-43 slight tweaks for a11y Radix-UI contrast is passing locally but not on LHCI
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621 - 👷 (github) NICE-43 turn off `e2e` at the moment - 👷 (vercel) NICE-43 vercel.json; + required env next-config - 👷 (github) NICE-43 put e2e back w/ env populated - 👷 (github) NICE-43 pass env to actions - ♿️ (radix-ui) NICE-43 color-contrast for tags (gray) - 🔧 (lhci) NICE-43 slight tweaks for a11y - Radix-UI contrast is passing locally but not on LHCI
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621 - 👷 (github) NICE-43 turn off `e2e` at the moment - 👷 (vercel) NICE-43 vercel.json; + required env next-config - 👷 (github) NICE-43 put e2e back w/ env populated - 👷 (github) NICE-43 pass env to actions - ♿️ (radix-ui) NICE-43 color-contrast for tags (gray) - 🔧 (lhci) NICE-43 slight tweaks for a11y - Radix-UI contrast is passing locally but not on LHCI
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App) Since this got the **squash** treatment all relevant information is #1621 - 👷 (github) NICE-43 turn off `e2e` at the moment - 👷 (vercel) NICE-43 vercel.json; + required env next-config - 👷 (github) NICE-43 put e2e back w/ env populated - 👷 (github) NICE-43 pass env to actions - ♿️ (radix-ui) NICE-43 color-contrast for tags (gray) - 🔧 (lhci) NICE-43 slight tweaks for a11y - Radix-UI contrast is passing locally but not on LHCI - 📝 NICE-43 a lot to do still...
Okay calling it here so I can then break out the rest of the work into smaller PRs. Anything not finished in the checklist will be a to-do.
And then as I go over this one last time (this is months in the making heh):
Kind of wish I put this as But I digress. |
This pull request has been deployed to Vercel.
|
This is a bit bigger than I would want, but this is a complete refactor to better utilize a
Notion CMS
within aNext 13 App
structure taking advantage ofRSC
. And then for good measure started the migration back toTailwind
(but now I thinkStitches|Vanilla Extract
are oaky with Next 13).✨ NICE-43 revamp Next RSC, Notion API, & Tailwind
BREAKING CHANGE: New Notion Implementation through Next 13 RSC (App)
Complete Refactor for Next RSC
Redis KV Cache
Image Component
Tailwind
@jeromefitz/ds
localized versionNotion Refactor
nodes
to more straight-forward componentsColumn|ColumnList
ListBulleted|ListItem|ListNumbered
TextAnnotations
Embed|Video
Embed.Twitter
<= Twitter is self-imploding, so good timing.Embed.YouTube
<= YouTube is ... no comment.Next
preload
=> hold on this for now not working as expectedgenerateMetadata
=> move away fromnext-seo
(rip)@vercel/og
-- or not temporarily.generateStaticParams
=> hack ifisDev
to stop running all the time :?not-found
=> Instead of customizing every route, usenotFound()
robots.ts|sitemap.ts
=> move away fromnext-sitemap
(rip)Package Upgrades
plaiceholder|semantic-release|syncpack
Other refactors
./packages/*
– this all needs to be ported to@jeromefitz/packages
pnpm linking
)Fathom advises against custom domains now :/
Layout
Not to be lost in the backend type stuff but this is a complete rehaul of presentation.
The eventual goal of this
Notion + Next
implementation is you can take the data in any way and display it as you would like. For now though still tightly coupled with a lot of decisions until I can abstract away further. Which -- at teh rate I am going may never happen.Notion
Do not "normalize" data from Notion, embrace it.
Formulas
The "big change" here is utilizing Notion Formulas in the CMS.
Slug
Before we had
Slug
now we populatedSlug.Preview
where we are able to have Notion mimic Routes better Server Side than figuring it all out on the fly innext
.Note: For
Events
we need to manually write theSlug
for now. The potential clash of having multiple Headline Acts means we could have a url like:../jerome-and,alex-o-jerome
Which I think could work because we could loop through but also very confusing as a URL to share, haha.
To recap:
Slug.Preview
for example will create the matching Next Segment Routejerome-and
(shows); After:/shows/jerome-and
jerome-and
(events); After:/events/2023/06/16/jerome-and
homepage
(pages); After:/
Date
Same here, instead of getting the data from Notion then running through
date-fns
, Notion usesmoment
(I think). So we can do more preparation which makes for a more straight-forward:Next
App
The gains of doing
[[...catchAll]]
for everything at root was not worth it. 😅Especially if we want to be able to change layout, RSC data points and more based on the Segment (Notion Database Type).
So there is some duplication of code throughout but will look into better ways of lifting the "same" stuff.
Events
Ability to see a range of events depending on Date (say for a week, or a weekend):
events/yyyy/mm/dd/to/yyyy/mm/dd
events/2023/06/29/to/2023/07/02
Props to Katie T. as we came up with this idea in a brainstorm session.
events/[from]/to/[to]
events/2023/06/15/to/2023/06/18
(THU-SUN)events/2023/06/29/to/2023/05/01
(Across Months)events/2023/12/28/to/2025/01/07
(Across Years)Probably need to do something for malformed dates, but I reckon
404
will do that.Up next would be ideas for
Landing Pages
.In-House
next-seo
andnext-sitemap
will eventually be absorded, or their functionality at least, withinnext
itself. This gets the ball rolling on that. They were awesome, and thank you.Depending on your use case those will still be very valid for use!
Packages
This just covers the
sites/jeromefitzgerald.com
for nowUpgrade:
Add:
Remove: