-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make meaningless encoding parameter from convert_file method deprecated #340
make meaningless encoding parameter from convert_file method deprecated #340
Conversation
@chrisdecker1201 I agree. We could remove it. Let me know what you think |
@JessicaTegner I think this is a good idea. But I've no idea how to set this property to deprecated. |
@chrisdecker1201 it's not that complicated, it is the following:
|
4e2fcd8
to
168a787
Compare
@JessicaTegner Like that? Thank you for taking your time for this 🙂 |
168a787
to
9a7c7c9
Compare
Signed-off-by: Christian Decker <[email protected]>
9a7c7c9
to
bf3089f
Compare
@JessicaTegner Just question: Do you just remove the parameter then in version 1.13 or should I prepare a PR? |
@chrisdecker1201 there is really 2 options.
|
I think this encoding parameter is a relic of copying the
convert_text
method, because it's not used.As far as I understood the current behavior of the
convert_file
method, it will just execute pandoc with the given file(s).I think there might be the possibility to implement the
encoding
parameter in two ways:Nevertheless, I think to remove confusion it might be the best solution to just remove the parameter :)