Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter to control if files are sorted before being passed to pandoc #378

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

colinbull
Copy link
Contributor

Small PR to allow the sorting behaviour to be controlled before the file sets are passed to the pandoc process. Previously files were always sorted. However, this can lead to the wrong ordering in the generated documents if the sorted order file names don't represent the required order in the generated documents.

pypandoc/__init__.py Outdated Show resolved Hide resolved
@JessicaTegner
Copy link
Owner

Hi @colinbull thanks for the pr.

I added a comment, and then there's some CI failing

@colinbull
Copy link
Contributor Author

Humm the build failing looks like python is failing to install correctly on the windows builds:

No Python at '"C:\hostedtoolcache\windows\Python\3.12.6\x64\python.exe'

Don't have time at the minute but will look at this, although it is likely not related to this PR.

@JessicaTegner
Copy link
Owner

yes indeed doesn't seem related. I'll try rerunning the failing jobs later, to see if it's a GH issue, cause it seems very strange.

@colinbull
Copy link
Contributor Author

No worries, I'll check back if they have passed then all good, if not I'll take a gander and submit a fix. Want a separate PR or happy to do it in here?

@JessicaTegner
Copy link
Owner

If it comes down to it, I would prefer a separate fix, and then we'll just merge main back into this

@JessicaTegner
Copy link
Owner

@colinbull it seems that the CI failing before was a fluke or something. It seems to be running now.
If you are finished with the pr. We can merge it

@colinbull
Copy link
Contributor Author

Ahhh, great. Sorry, I actually completely forgot I said I'd look at this.

As far as I'm concerned this is complete. So happy to merge.

@JessicaTegner JessicaTegner merged commit 8bc3c51 into JessicaTegner:master Oct 27, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants