Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchChangelog breaks changelog format in version 2.1.0 #176

Closed
danygold opened this issue Jun 22, 2023 · 1 comment · Fixed by #177
Closed

patchChangelog breaks changelog format in version 2.1.0 #176

danygold opened this issue Jun 22, 2023 · 1 comment · Fixed by #177
Labels
bug Something isn't working
Milestone

Comments

@danygold
Copy link
Contributor

Describe the bug
patchChangelog in version 2.1.0 breaks changelog format adding unneccessary new line.

To Reproduce
Use CHANGELOG.md and run gradle patchChangelog

Expected behavior
Changelog is patched and format is not manipulated.

Environment:

  • OS: Windows 11
  • Gradle Changelog Plugin Version 2.1.0
  • Gradle Version 8.1.1

Additional context
In previous version before 2.1.0, patchCahngelog works propertly as expected

@danygold danygold added the bug Something isn't working label Jun 22, 2023
@danygold
Copy link
Contributor Author

I've investigated and seems that the issue is caused by this issue on markdown component.
In fact if i use a CHANGELOG.md that use LF line separator, issue is not present. Instad, if file use CRLF or CR, patchChangelog breaks my changelog format.

The only solution that i've found is to use the LF line separator in CHANGELOG.md.

fioan89 added a commit to fioan89/sourcesync that referenced this issue Jun 30, 2023
@hsz hsz closed this as completed in #177 Jul 6, 2023
@hsz hsz added this to the 2.1.1 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants