Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate intelij navigation history together with ideavim jumplist #224

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

pmnoxx
Copy link
Contributor

@pmnoxx pmnoxx commented Feb 18, 2020

Currently we keep intelij navigation history separate from ideavim jumplist.
This change will cause all updates to ideavim jumplist to be propagated to intelij navigaration history as well.

https://youtrack.jetbrains.com/issue/VIM-44

@AlexPl292
Copy link
Member

Hi @pmnoxx !
As I see, there are still some improvements needed to close this issue, but it works better now. Thank you for your PR!

@AlexPl292 AlexPl292 merged commit 9f1e80e into JetBrains:master May 6, 2020
@pmnoxx
Copy link
Contributor Author

pmnoxx commented May 6, 2020

Hi @AlexPl292

I also figured how to make ctrl-o, ctrl-O call back / forward actions in intellij. I can make a PR for it.

In order to fully support jumplist (:jumps operation), printing jumplist. I would need to figure out how to get jumplist from intellij. I couldn't figure it out yet. I spend a few hours trying. Then it would be possible to remove internal jumplist data structure completely.

@AlexPl292
Copy link
Member

Yep, great! Just make a PR and we'll discuss the details.

Regarding the internal structure of jumplist. Yes, this would be great if we could get rid of this structure, but before that, we should make sure that IJ jumps work the same as vim jumps. Unfortunatelly, we haven't made any investigations on this question yet.

@kjyv
Copy link

kjyv commented Sep 4, 2020

So, I'm running 0.59 and don't see this working. Any settings necessary for the jumplists to be joined?

@PetrusZ
Copy link

PetrusZ commented Nov 28, 2020

Not see this working on 0.61 too.

@6a6ai
Copy link

6a6ai commented Feb 3, 2021

it's broken. Please seriously consider using neovim as an embedded editor and retiring ideavim, I and a few other paying users are seriously upset by that and considering dropping the IDE in favour of other solutions.

@pmnoxx
Copy link
Contributor Author

pmnoxx commented Feb 3, 2021

I'll try to create a PR during the weekend.

@6a6ai
Copy link

6a6ai commented Feb 4, 2021

I'll try to create a PR during the weekend.

Thank you for the reply!

Why not bind to ctrl+o, ctrl+i - the standard vim commands for jumping back and forward? The problem now is that ctrl-o/ctrl-i are functioning within the file, until you select another file and move around there - then you end up in random places if you try to use them.

I tried rebinding them to :action Back & :action Forward -> didn't work propertly as well.

@isudfv
Copy link

isudfv commented Aug 24, 2022

On windows ideavim jumplist is not propagated to intelij navigaration history so <Action>(Back) doesn't work in cases like 2j

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants