Use new API for relative line numbers #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes VIM-1934, fixes VIM-1852
Fixes VIM-2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new line number converter API to provide relative line numbers. This allows specifying the largest line number (the old API would get the converted line number of the last line, which could have a single digit, while the caret line could have multiple digits). This could also cause "flickering" as the expected width of the text gutter changes. Fixes VIM-1934 and VIM-1852.
Also fixes an issue where moving the text caret would re-initialise line numbers. Now it simply repaints. Fixes VIM-2021