Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIM-1476 #295

Merged
merged 2 commits into from
Apr 28, 2021
Merged

VIM-1476 #295

merged 2 commits into from
Apr 28, 2021

Conversation

MichalPlacek
Copy link
Contributor

No description provided.

@MichalPlacek
Copy link
Contributor Author

@AlexPl292 I don't know why TeamCity build failed. I have not worked with this tool before so I don't know why it didn't work.

@AlexPl292
Copy link
Member

We have some issues with configuration, sorry for that.

@MichalPlacek
Copy link
Contributor Author

This is ready to merge (the problem is only with "TeamCity build failed")

@AlexPl292 AlexPl292 merged commit 96dbbcf into JetBrains:master Apr 28, 2021
@AlexPl292
Copy link
Member

Hi! Sorry for the delay. Actually, it looks like this case is a bit more complicated than expected. Because at the moment lastKeys contain a list of "raw" commands, so in case if user types ab then presses left arrow and types c (acb in the result), we should also process this left arrow for correct . register representation. But since in IdeaVim dot register has only representation purpost, I guess this small inconsistency can be ignored at the moment.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants