Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version property unification #171

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Version property unification #171

merged 1 commit into from
Apr 11, 2020

Conversation

turansky
Copy link
Collaborator

Common template - $id.version

Dependency id Example
NPM $packageName react-dom
Kotlin $projectId kotlinx-html
Gradle plugin $name-plugin bintray-plugin

Existed examples:

@Leonya Leonya merged commit fc863eb into JetBrains:1.4-js-ir Apr 11, 2020
@Leonya
Copy link
Collaborator

Leonya commented Apr 12, 2020 •
edited
Loading

@turansky I have just noticed that there are lots of "Could not resolve project" errors when importing the project in IDEA (1.4-js-jr branch). It builds fine from the command line, but IDEA is unhappy. Please take a look.

error

@turansky
Copy link
Collaborator Author

turansky commented Apr 12, 2020 •
edited
Loading

@Leonya

IDEA unhappy (current)

kotlin.js.compiler=both

IDEA happy (WA)

kotlin.js.compiler=legacy

Do you have same results?

@Leonya
Copy link
Collaborator

Leonya commented Apr 12, 2020

Yes, thanks.

@turansky
Copy link
Collaborator Author

KT-38214

@turansky turansky deleted the version-property-unification branch April 15, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leonya Leonya Leonya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turansky @Leonya