Add wrappers for null-writable #2529
Conversation
| import node.buffer.BufferEncoding | ||
| import node.stream.Writable | ||
|
|
||
| external class NullWritable : Writable { |
There was a problem hiding this comment.
Looks like we can just add implementation from original (2 lines of code) and remove Karakum generation :)
There was a problem hiding this comment.
Yes, if you prefer, we can do it.
I just thought where possible, generation is preferable.
There was a problem hiding this comment.
I even made a PR to that project first to bring the declaration in line with upstream declaration, so that the generation immediately generates the proper declarations that can override :-D
There was a problem hiding this comment.
Yes, if you prefer, we can do it.
Yes, please.
Especially when we know about open problem with NCC packaging.
There was a problem hiding this comment.
I don't get what you are saying.
The NCC packaging problem has nothing to do with whether the sources are generated or manually checked in.
I tried it in a pure plain old TS project and it happened there just the same.
No description provided.