Use ComponentClass instead of RClass
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turansky
approved these changes
Jul 24, 2021
sgrishchenko
requested changes
Jul 25, 2021
| @@ -3,8 +3,8 @@ package react.router.dom | |||
| import react.* | |||
| import kotlin.reflect.KClass | |||
|
|
|||
| fun <P : RProps> withRouter(klazz: KClass<out Component<P, *>>): RClass<P> = | |||
| fun <P : RProps> withRouter(klazz: KClass<out Component<P, *>>): ComponentClass<P> = | |||
There was a problem hiding this comment.
I think we need some analysis for these changes. For example, it seems we should use ComponentType here because we should not know how withRouter HOC implemented. It can return FunctionComponent under the hood, but we are saying that it is Class. I recommend use ComponentType everywhere it is possible in libraries for returned types and use ComponentClass only if it is really needed.
There was a problem hiding this comment.
Looks like next PR (check required before)
|
Released in pre.222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @turansky @sgrishchenko