Prepare Component Props for more strict restrictions #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turansky
reviewed
Aug 7, 2021
| @@ -13,8 +13,8 @@ external interface QueryErrorResetBoundaryValue { | |||
|
|
|||
| external val useQueryErrorResetBoundary: () -> QueryErrorResetBoundaryValue | |||
|
|
|||
| external interface QueryErrorResetBoundaryProps : react.RProps { | |||
| var children: dynamic | |||
| external interface QueryErrorResetBoundaryProps : react.Props { | |||
There was a problem hiding this comment.
PropsWithChildren? I will fix it in generator
There was a problem hiding this comment.
https://react-query.tanstack.com/reference/QueryErrorResetBoundary
There should be render children, not Array<ReactNode>
turansky
approved these changes
Aug 7, 2021
| @@ -16,10 +16,6 @@ abstract class RComponent<P : RProps, S : State> : Component<P, S> { | |||
| // if you use this method, don't forget to pass props to the constructor first | |||
| open fun S.init(props: P) {} | |||
|
|
|||
| fun RBuilder.children() { | |||
There was a problem hiding this comment.
Yea, there is context(RBuilder) PropsWithChildren.children(), this declaration in more obvious, it is impossible to declare such method in RComponent because we don't know will inheritor implements PropsWithChildren or not
Leonya
reviewed
Aug 7, 2021
| external interface QueryErrorResetBoundaryProps : react.RProps { | ||
| var children: dynamic | ||
| external interface QueryErrorResetBoundaryProps : react.Props { | ||
| var children: dynamic |
There was a problem hiding this comment.
I will regenerate react-query wrappers after this PR
aerialist7
approved these changes
Aug 8, 2021
|
Released in pre.228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are typing vulnerability of currents props: every component now can have children with type
Array<ReactNode>, even it is not declared obviously. Also there is conflict of names and now there are difficulties with creation of children with custom type (e.g. render children)This PR - first step to make
Propsmore strict.TS typings
Part of #358
cc @turansky @aerialist7