Support Java 8 #416
Support Java 8 #416
Conversation
There was a problem hiding this comment.
@zhelenskiy, thanks for the change! I've left several comments, could you please take a look?
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
| @@ -20,7 +20,7 @@ import java.lang.reflect.Field | |||
| /** | |||
| * Helper object to provide the field name and the owner of the VarHandle method call. | |||
| */ | |||
| @Suppress("SameParameterValue") | |||
| @Suppress("SameParameterValue", "Since15") | |||
There was a problem hiding this comment.
Why is Since15 necessary here?
There was a problem hiding this comment.
To suppress Idea warnings about usage of since JDK 9 API.
There was a problem hiding this comment.
How can since JDK 9 API usages be in the code with the source level being Java 8?
There was a problem hiding this comment.
Because there are several conflicting sources of JVM versions and IDEA takes the wrong one here to highlight. When compiled with JDK > 8, it works well; otherwise, this part is not compiled. Btw, the rule is applicable to the JDK9+ tests, not the LinCheck source (this file). There are no such suppressions in the source part anymore.
src/jvm/main/org/jetbrains/kotlinx/lincheck/util/AtomicMethods.kt
Outdated
Show resolved
Hide resolved
| @@ -8,6 +8,8 @@ | |||
| * with this file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
| */ | |||
|
|
|||
| @file:Suppress("Since15") | |||
There was a problem hiding this comment.
Is this suppression necessary?
| @@ -243,6 +243,7 @@ class UnsafeLocalObjectsTest { | |||
| * If we hadn't such check, this test would hang due to infinite spin-loop on a local object operations with | |||
| * no chances to detect a cycle and switch. | |||
| */ | |||
| @Suppress("Since15") | |||
There was a problem hiding this comment.
Is this suppression necessary?
src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/FixedActiveThreadsExecutor.kt
Outdated
Show resolved
Hide resolved
|
@zhelenskiy Please also run the tests on the following build configurations: |
zhelenskiy
force-pushed
the
jvm-target-8
branch
from
cdac723
to
0816809
Compare
|
Rebased on master |
|
Manually run build for 8 passes the tests. |
No description provided.