Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin/Native and C/C++ support #68

Open
wants to merge 76 commits into
base: develop
Choose a base branch
from
Open

Kotlin/Native and C/C++ support #68

wants to merge 76 commits into from

Conversation

Krock21
Copy link
Contributor

@Krock21 Krock21 commented Dec 3, 2020

No description provided.

@Krock21 Krock21 marked this pull request as ready for review December 3, 2020 21:27
@Krock21 Krock21 requested a review from ndkoval December 4, 2020 19:24
ndkoval
ndkoval requested changes Dec 6, 2020
View reviewed changes
Copy link
Collaborator

@ndkoval ndkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I've reviewed a part of PR now, will review the rest later. Please look at the comments in the meanwhile.

There are also two questions:

  1. What does "easy part" in the PR title mean?
  2. Is there still any code in Java?

src/jvm/main/org/jetbrains/kotlinx/lincheck/LinChecker.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/LinChecker.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/Utils.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/annotations/LogLevel.kt Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/annotations/OpGroupConfig.kt Outdated

import java.lang.annotation.Inherited
import java.lang.annotation.Repeatable
import java.lang.annotation.Retention
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please configure annotations written in Kotlin with the mechanism provided by Kotlin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeatable annotation from java can't be replaced by kotlin's one

src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ByteGen.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ByteGen.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/DoubleGen.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/DoubleGen.kt Outdated Show resolved Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/DoubleGen.kt Outdated Show resolved Hide resolved
@Krock21 Krock21 changed the title Switch from Java to Kotlin. Easy part Switch from Java to Kotlin Dec 7, 2020
Krock21 and others added 22 commits December 22, 2020 14:48
@Krock21
Move some parts to common
672bff0
@Krock21
Merge remote-tracking branch 'origin/develop' into move-to-common
ff4da1d 
# Conflicts:
#	src/jvm/main/org/jetbrains/kotlinx/lincheck/CTestStructure.java
#	src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/ParallelThreadsRunner.kt
#	src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
#	src/jvm/test/org/jetbrains/kotlinx/lincheck/test/representation/AFUCallRepresentationTest.kt
@Krock21
Add Boolean default gen to defaultGens
5f1b013
@Krock21
Move some parts to common
ec07ae3
@Krock21
Move some parts(#2) to common
de4f0dd
@Krock21
Move some parts to common(3), change sequentialSpecification internal…
39c055e 
… type from Class to KClass
@Krock21
Fix tests, KClass<out Any> -> KClass<*>
c60f93c
@Krock21
move ValueResult and ExceptionResult in common
1a11040
@Krock21
Move LincheckFailure, InvocationResult, and Reporter to common
1f0f968
@Krock21
abstract SequentialSpecification, move LTS
945cc27
@Krock21
move verifiers to common
ac46f5b
@Krock21
replace testClass: Class<*> by TestClass abstraction
0c2b606
@Krock21
Move Options to common, strange fixes for SequentialSpecification, Ve…
ec80ba5 
…rifierClass, ExecutionGeneratorClass
@Krock21
move annotation to jvm, fix some unused expect-actual
069c0ba
@ndkoval
Get rid of WeakHashMap in CachedVerifier
f6825ab
@ndkoval
Get rid of WeakHashMap in QuiescentConsistencyVerifier
362e152
@ndkoval
Meeting changes
cf0bd5f
@Krock21
fix last commit, break java api
5c1a4ef
@Krock21
Move Runner and StressStrategy to common, make ParallelThreadsRunner …
1ff8375 
…expect-actual
@Krock21
Merge remote-tracking branch 'origin/develop' into java-to-kotlin
fb45647 
# Conflicts:
#	src/jvm/main/org/jetbrains/kotlinx/lincheck/Utils.kt
@Krock21
add native platform, fix stable state
a72dcef
@Krock21
another stable state
71fce28
@Krock21
minor fixes
a1d7f64
@Krock21
Merge remote-tracking branch 'origin/java-to-kotlin' into java-to-kotlin
41e24e7
@Krock21
Add junction and torf cpp example
ba00819
@Krock21
Add libcuckoo test, some fixes in lincheck
fd32a2b
@Krock21
Add folly ConcurrentHashMap test
53edf81
@Krock21
Add boost::lockfree::queue test, fix bugs in Lincheck
a96b940
@Krock21
enable libcuckoo_test
c5163ab
@Krock21
Fix memory issue
962fb29
@Krock21
Fix git submodules, add progress debug output
027abc3
@Krock21
switch from debugShared to releaseShared
a50b8f7
@Krock21
fix test_failing test
74d164e
@Krock21
increase iterations count in AbstractLincheckStressTest
949eb7f
@Krock21
set up parameters for tests
e3350e9
@Krock21
Add more c++ tests
a90e7e8
@Krock21
Add operation groups to native, add NonParallelOpGroupTest, add boost…
97650e8 
…:locfree::spsc_queue test. Add folly [SM]P[SM]CQueue tests
@Krock21
Improve tests stability
b5c5f46
@Krock21
Improve NonParallelOpGroupTest stability
f41271e
@Krock21
Fix UnexpecedExceptionTest
8dc92a5
@Krock21
Fix UnexpecedExceptionTest with atomic
2029c5f
@Krock21
Fix HashMapTest possible IllegalStateException
ce7560b
@Krock21
Fix HashMapTest possible UnexpectedExceptionFailure(IllegalStateExcep…
db71d4a 
…tion from HashMap)
@Krock21
Attempt to fix UnexpectedExceptionTest
d30852b
@Krock21
Add ValidationTest
e71ad98
@Krock21
Add EpsilonVerifierTest
4a27867
@Krock21
add scenario finalization, minor fixes
bba9648
@Krock21
Add import
d8993d4
@Krock21
Fix OpGroupTests
b8bcfee
@Krock21
improve cpp tests and fix some bugs
faed7ed
@Krock21
Merge develop into java-to-kotlin
65d46c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
postponed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krock21 @ndkoval