Change the file listener to use a invokeLater action

JetBrains · Aug 12, 2021 · 45568f8 · 45568f8
1 parent 87d65e4
commit 45568f8
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 33 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 # PEST IntelliJ Changelog
 
 ## [Unreleased]
+### Fixed
+- Invoke the FileListener PSI part later (should fix indexing issues)
+
+## [1.0.5]
 ### Changed
 - Bumped min IntelliJ version to 2021.1
 

diff --git a/gradle.properties b/gradle.properties
@@ -3,7 +3,7 @@
 
 pluginGroup = com.pestphp
 pluginName = PEST PHP
-pluginVersion = 1.0.5
+pluginVersion = 1.0.6
 
 # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 # for insight into build numbers and IntelliJ Platform versions.

diff --git a/src/main/kotlin/com/pestphp/pest/fileListeners/ExtendAsyncFileListener.kt b/src/main/kotlin/com/pestphp/pest/fileListeners/ExtendAsyncFileListener.kt
@@ -1,5 +1,6 @@
 package com.pestphp.pest.fileListeners
 
+import com.intellij.openapi.application.invokeLater
 import com.intellij.openapi.components.service
 import com.intellij.openapi.externalSystem.autoimport.AsyncFileChangeListenerBase
 import com.intellij.openapi.project.NoAccessDuringPsiEvents
@@ -26,25 +27,24 @@ class ExtendAsyncFileListener : AsyncFileChangeListenerBase() {
     }
 
     override fun updateFile(file: VirtualFile, event: VFileEvent) {
-        try {
-            ProjectManager.getInstance()
-                .openProjects
-                // Only look at projects where the file is inside.
-                .filter { ProjectFileIndex.getInstance(it).isInContent(file) }
-                // Get the PSI file inside each of the projects.
-                .mapNotNull { PsiManager.getInstance(it).findFile(file) }
-                // Only look at PHP files
-                .filterIsInstance<PhpFile>()
-                .filter { it.expectExtends.isNotEmpty() }
-                .forEach {
-                    val expectationFileService = it.project.service<ExpectationFileService>()
+        ProjectManager.getInstance()
+            .openProjects
+            // Only look at projects where the file is inside.
+            .filter { ProjectFileIndex.getInstance(it).isInContent(file) }
+            // Get the PSI file inside each of the projects.
+            .mapNotNull { PsiManager.getInstance(it).findFile(file) }
+            // Only look at PHP files
+            .filterIsInstance<PhpFile>()
+            .forEach {
+                val expectationFileService = it.project.service<ExpectationFileService>()
 
-                    // In case file is deleted.
-                    if (event is VFileDeleteEvent) {
-                        expectationFileService.removeExtends(it.virtualFile)
-                        return@forEach
-                    }
+                // In case file is deleted.
+                if (event is VFileDeleteEvent) {
+                    expectationFileService.removeExtends(it.virtualFile)
+                    return@forEach
+                }
 
+                invokeLater {
                     // Add all the extends
                     val hasChanges = expectationFileService.updateExtends(it)
 
@@ -53,20 +53,7 @@ class ExtendAsyncFileListener : AsyncFileChangeListenerBase() {
                         expectationFileService.generateFile()
                     }
                 }
-        } catch (exception: Exception) {
-            // Ignore up to date stub mismatch exceptions
-            if (exception.javaClass.simpleName.equals("UpToDateStubIndexMismatch")) {
-                return
-            }
-            if (exception.stackTrace.any { it.methodName.equals("stubTreeAndIndexDoNotMatch") }) {
-                return
             }
-            if (exception.stackTrace.any { it.className.equals(NoAccessDuringPsiEvents::class.java.name)}) {
-                return
-            }
-
-            throw exception
-        }
     }
 
     override fun isRelevant(file: VirtualFile, event: VFileEvent): Boolean {

diff --git a/src/main/kotlin/com/pestphp/pest/services/ExpectationFileService.kt b/src/main/kotlin/com/pestphp/pest/services/ExpectationFileService.kt
@@ -1,6 +1,9 @@
 package com.pestphp.pest.services
 
 import com.intellij.openapi.application.ApplicationManager
+import com.intellij.openapi.application.invokeLater
+import com.intellij.openapi.application.runWriteAction
+import com.intellij.openapi.progress.runSuspendingAction
 import com.intellij.openapi.project.DumbService
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.vfs.VirtualFile
@@ -73,8 +76,8 @@ class ExpectationFileService(val project: Project) {
         val file = generator.generateToFile(project)
 
         // Save the file in vendor folder
-        ApplicationManager.getApplication().invokeLater {
-            ApplicationManager.getApplication().runWriteAction {
+        invokeLater {
+            runWriteAction {
                 DumbService.getInstance(project).suspendIndexingAndRun(
                     "Indexing Pest expect extends"
                 ) {