[phpstorm-stubs] Updated deprecations for PHP 8.4 #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isfedorov
reviewed
Oct 28, 2024
dba/dba.php
Outdated
| @@ -372,6 +372,6 @@ function dba_list(): array {} | |||
| * value_name). This function will return <b>FALSE</b> if | |||
| * <i>key</i> is <b>NULL</b> or <b>FALSE</b>. | |||
| */ | |||
| function dba_key_split(string|false|null $key): array|false {} | |||
| function dba_key_split(#[LanguageLevelTypeAware(["8.4" => "string"], default: "string|false|null")] $key): array|false {} | |||
There was a problem hiding this comment.
Should this be changed? Could you please share a link on RFC or PHP change?
There was a problem hiding this comment.
Found it here php/php-src@bb2836e
"Passing null or false to dba_key_split() is deprecated"
There was a problem hiding this comment.
Such deprecation can't be configured with different typehints in sugnature. Please see https://youtrack.jetbrains.com/issue/WI-79525/Deprecations-for-PHP-8.4 . A separate inspection should be done for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.