Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltips for Unity code vision #1206

Merged
merged 1 commit into from
May 28, 2019
Merged

Update tooltips for Unity code vision #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions resharper/resharper-unity/src/Rider/CodeInsights/RiderUnityHighlightingContributor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,7 @@ private void AddHighlighting(IHighlightingConsumer consumer,

var iconId = isIconHot ? InsightUnityIcons.InsightHot.Id : InsightUnityIcons.InsightUnity.Id;
consumer.AddHighlighting(new UnityCodeInsightsHighlighting(element.GetNameDocumentRange(),
// TODO pass tooltip correctly (waiting sdk update)
displayName, displayName, codeInsightsProvider, declaredElement,
displayName, tooltip, displayName, codeInsightsProvider, declaredElement,
myIconHost.Transform(iconId), CreateBulbItemsForUnityDeclaration(element), extraActions));
}

Expand Down
4 changes: 2 additions & 2 deletions resharper/resharper-unity/src/Rider/CodeInsights/UnityCodeInsightsHighlighting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ public class UnityCodeInsightsHighlighting : CodeInsightsHighlighting, IUnityHig
{
public const string Id = "UnityCodeInsights";

public UnityCodeInsightsHighlighting(DocumentRange range, [NotNull] string lenText, [NotNull] string moreText,
public UnityCodeInsightsHighlighting(DocumentRange range, [NotNull] string lenText, [NotNull] string tooltipText, [NotNull] string moreText,
[NotNull] ICodeInsightsProvider provider, IDeclaredElement element,
[CanBeNull] IconModel icon, IEnumerable<BulbMenuItem> menuItems,
List<CodeLensEntryExtraActionModel> extraActions = null)
: base(range, lenText, moreText, provider, element, icon, extraActions)
: base(range, lenText, tooltipText, moreText, provider, element, icon, extraActions)
{
MenuItems = menuItems.ToList();
}
Expand Down