Make CSS an optional dependency #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RIDER-36523
|
Feel free to comment on wording, etc.
|
kashmervil
approved these changes
Dec 9, 2019
| fun isUxmlFile(file: VirtualFile) = file.extension.equals("uxml", true) |
There was a problem hiding this comment.
it's a better practice to operate with file types rather than with actual hard-coded strings comparison. custom file associations can be added, there could be another extension in the future etc.
This is not a big problem for your scenario, and you also covered the 'ignore case' thing, but still...
Consider using FileTypeRegistry#isFileOfType is possible
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the CSS tooling to provide USS support. But if CSS is disabled in plugins, the entire Unity plugin is also disabled. This PR makes the CSS support an optional dependency. See RIDER-36523.
*.ussfiles if CSS is disabled, prompting to re-enable the plugin, and show a toast notification to restart.This PR also adds the correct icons for
*.ussand*.uxmlfiles (see RIDER-34788)