Add Unity specific spell check dictionaries #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerzhulart
suggested changes
Mar 16, 2020
| myLogger = logger; | ||
| } | ||
|
|
||
| public void InitialiseSolutionSettings(ISettingsStorageMountPoint mountPoint) |
There was a problem hiding this comment.
If it's called on startup on the Main thread it may increase startup time (reading of reasources). It's better to queue on a background thread (see HunspellBackend.cs for example)
...per-unity/src/CSharp/Feature/Respeller/ReSharper/UnityInstalledDictionarySettingsProvider.cs
Outdated
Show resolved
Hide resolved
...per-unity/src/CSharp/Feature/Respeller/ReSharper/UnityInstalledDictionarySettingsProvider.cs
Outdated
Show resolved
Hide resolved
...per-unity/src/CSharp/Feature/Respeller/ReSharper/UnityInstalledDictionarySettingsProvider.cs
Outdated
Show resolved
Hide resolved
citizenmatt
changed the title
They don't work properly with plugins - the checks are designed to work with zone definitions defined in source code, not consumed from references. There is also a module consistency check to ensure that zones for namespaces in different projects are consistent. This assumes all modules are related, and doesn't work with multiple modules that have no relationship. I.e. it tries to make the Rider and ReSharper modules consistent, which can't work because one will require VS zones, and the other will require Rider/ReSharperHost zones.
It has more to do with naming that spellcheck
citizenmatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Unity specific dictionary + abbreviation list to Rider + ReSharper.
unity.dicfile is added as a frontend dictionary for Rider, which can be enabled/disabled as required.unity.dicand an emptyunity.afffiles are used as a backend dictionary for ReSharper, which can also be enabled/disabled as required. Note that theunity.afffile is empty. It lists the rules for suffixes/prefixes, and is required, but is allowed to be empty.