Call-graph based Unity.Burst support #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 2, 2020 18:52
2. fixed unityProblemAnalyzerContext switches 3. sdk compilation fixes
…on based on recursive processor
2. test fixes 3. unity jobs defining 4. test attribute mark added
krasnotsvetov
requested changes
May 30, 2020
...-unity/src/CSharp/Daemon/Stages/BurstCodeAnalysis/Analyzers/BurstForeachStatementAnalyzer.cs
Outdated
Show resolved
Hide resolved
...nity/src/CSharp/Daemon/Stages/BurstCodeAnalysis/Analyzers/BurstStringLiteralOwnerAnalyzer.cs
Outdated
Show resolved
Hide resolved
...er/resharper-unity/test/data/CSharp/Daemon/Stages/BurstCodeAnalysis/resharper/ComplexTest.cs
Outdated
Show resolved
Hide resolved
...er/resharper-unity/test/data/CSharp/Daemon/Stages/BurstCodeAnalysis/resharper/ComplexTest.cs
Outdated
Show resolved
Hide resolved
...rp/Daemon/Stages/PerformanceCriticalCodeAnalysis/CallGraph/ExpensiveCodeCallGraphAnalyzer.cs
Outdated
Show resolved
Hide resolved
...s/PerformanceCriticalCodeAnalysis/CallGraph/PerformanceCriticalCodeCallGraphMarksProvider.cs
Show resolved
Hide resolved
...er-unity/src/CSharp/Daemon/Stages/BurstCodeAnalysis/CallGraph/CallGraphBurstMarksProvider.cs
Outdated
Show resolved
Hide resolved
resharper/resharper-unity/src/CSharp/Daemon/Stages/BurstCodeAnalysis/BurstCodeAnalysisUtil.cs
Show resolved
Hide resolved
resharper/resharper-unity/src/CSharp/Daemon/Stages/BurstCodeAnalysis/BurstCodeAnalysisUtil.cs
Outdated
Show resolved
Hide resolved
added 8 commits
June 3, 2020 01:38
2. test additions and fixes 3. multiple PerformanceCriticalCodeCallGraphMarksProvider.cs and ExpensiveCodeCallGraphAnalyzer.cs fixes and enhancements 4. burst ui 5.
2. BurstCodeAnalysisUtil.cs refactoring and clarifying
…nalysis possible flicks
…vent spreading burst context
citizenmatt
requested changes
Jun 23, 2020
There was a problem hiding this comment.
- I'm not sure if these new highlights should be configurable severity. If they're compiler errors, can't be disabled, and will break compilation, we should treat them as static severity. We can always disable analysis in options if there are problems
- We shouldn't show the compiler ID as part of the warning - we don't do this anywhere else, e.g. for C# compiler errors/warnings, although I think we can associate a highlight with. It also makes it harder to read the code to know what the highlight is about.
- Replace the backtick
</code> with single quote'` to match other R#/Rider messages - Remove all full stops from the end of
<Message>attributes. We don't end tooltips with a full stop.
Are the tooltip messages/descriptions taken from the compiler error messages? We might want to do something a little more user friendly, like we do with C# compiler messages.
resharper/resharper-unity/src/Application/UI/Options/VisualStudio/ReSharperOptionsPage.cs
Outdated
Show resolved
Hide resolved
| { | ||
| public CallGraphBurstMarksProvider(ISolution solution) | ||
| : base(nameof(CallGraphBurstMarksProvider), | ||
| new CallGraphOutcomingPropagator(solution, nameof(CallGraphBurstMarksProvider))) |
There was a problem hiding this comment.
I know it's an SDK method, but should Outcoming be Outgoing?
There was a problem hiding this comment.
Outcoming was chosen to show that it is opposite toIncomingPropagator, so idk if this is correct change
|
|
||
| <SeverityConfiguration> | ||
| <Group name="UnityHighlightingGroupIds.Burst"> | ||
| <Tag externalName="BC1001Error.HIGHLIGHTING_ID" default="WARNING"> |
There was a problem hiding this comment.
Should this be an error highlight instead of a warning? And unless these can be disabled, shouldn't they be static highlights?
There was a problem hiding this comment.
Burst compiler is a special case: if compiled at the editor - despite unsuccessful compilation unity project will be executed, if built as standalone - unity will consider it as a normal error, so I think warning is the best severity, let the user decide if this is critical for him
resharper/resharper-unity/src/CSharp/Daemon/Stages/Highlightings/UnityHighlightingGroupIds.cs
Outdated
Show resolved
Hide resolved
resharper/resharper-unity/src/CSharp/Daemon/Stages/Highlightings/UnityHighlightingGroupIds.cs
Outdated
Show resolved
Hide resolved
| <SeverityConfiguration> | ||
| <Group name="UnityHighlightingGroupIds.Burst"> | ||
| <Tag externalName="BC1001Error.HIGHLIGHTING_ID" default="WARNING"> | ||
| <Title>BC1001</Title> |
There was a problem hiding this comment.
I think these titles need more information - I think they're used to display the warning in the Inspection Severity page, and should reflect the tooltip, rather than the compiler ID
resharper/resharper-unity/src/CSharp/Daemon/Errors/BurstErrors.xml
Outdated
Show resolved
Hide resolved
Domonion
force-pushed
the
net202-kononov-cg
branch
2 times, most recently
from
3f413d6
to
acdc899
Compare
Domonion
force-pushed
the
net202-kononov-cg
branch
from
acdc899
to
e74c698
Compare
added 15 commits
June 25, 2020 05:12
…arper-unity into net202-kononov-cg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Unity.Burst
highlights access to managed objects, object creation etc
transitively propagates burst contexts
highlighting are taken and annotated to match Burst compiler