Map range attribute to value range annotation #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches Unity behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReSharper/Rider 2020.1 introduced integer value dataflow analysis, which can track the value of integers through a piece of code. The
ValueRangeattribute can provide a hint that an integer value is only between a min and max value.Unity's
Rangeattribute can be applied to fields, and the Inspector will ensure that the value of the field is kept between the given min and max value.This PR will map Unity's
Rangeattribute to ReSharper'sValueRangeannotation, using theRange's min/max values as the hint to ReSharper's dataflow analysis. Note that ReSharper's analysis only works with integer values, soRangeattributes on float values are ignored.