-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunch of smaller fixes #1923
Bunch of smaller fixes #1923
Conversation
This attribute can be used on MonoBehaviour and ScriptableObject. See #145
The [Inject] API was removed from the Entities package around 0.25. See https://forum.unity.com/threads/api-deprecation-faq-0-0-23.636994/
Recognises fields marked with [SerializeReference] as serialised fields. Also supports the type of the field being an abstract type Fixes #1340
Fixes part of RIDER-18729
Doesn't add tests for providers based on folder structure Fixes #626
resharper/resharper-unity/src/CSharp/Daemon/UsageChecking/UsageInspectionsSuppressor.cs
Show resolved
Hide resolved
...src/CSharp/Feature/Services/TypeConversionHints/CSharpTypeConversionHintsSettingsProvider.cs
Show resolved
Hide resolved
@@ -163,7 +166,7 @@ class UnityLogPanelView(lifetime: Lifetime, project: Project, private val logMod | |||
@Suppress("SpellCheckingInspection") | |||
private val listPanel = JPanel(MigLayout("ins 0, gap 0, flowy, novisualpadding, fill", "", "[][min!]")).apply { | |||
add(JBScrollPane(eventList).apply { horizontalScrollBarPolicy = ScrollPaneConstants.HORIZONTAL_SCROLLBAR_NEVER }, "grow, wmin 0") | |||
add(searchTextField, "growx") | |||
add(searchTextField, "grow") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @van800
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert in that UI tweaks, but I tried the branch and this change doesn't brake the layout of UnityLogView.
@citizenmatt what this change does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means the search field will grow both in x and y. So it was stretching to fit horizontally, but didn't grow vertically, so if there was a larger font, the height would be wrong.
resharper/resharper-unity/src/CSharp/Psi/CodeAnnotations/CustomCodeAnnotationProvider.cs
Show resolved
Hide resolved
yield break; | ||
var version = project != null | ||
? context.Solution.GetComponent<UnityVersion>().GetActualVersion(project) | ||
: context.Solution.GetComponent<UnityVersion>().ActualVersionForSolution.Value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather check ActualVersionForSolution first. It might be faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine for now. We're using GetActualVersion(IProject)
in lots of places, including UnityApi
for completion, usage suppression and so on. I'm up for reviewing UnityVersion
usage in 211 though - it might be worth removing the IProject
API completely.
Vector3
implicitly converted toVector2
loses information. These hints are push-to-hint by default[Range]
attribute analysis - Custom annotation provider for Range attribute not working #1788[SerializeField]
attributes on fields of typeT
- Incorrect redundant serialise field warning for field of the generic type of the class #1885[SerializeReference]
not being recognised as serialised field - Add support for SerializeReference #1340Dictionary<TKey, TValue>
being treated as a serialisable field - Dictionary fields are treated as serialisable fields #1776Vector2Int
,BoundsInt
, etc. - see RIDER-18729sfield
andsprop
live templates missing in[Serializable]
types - Cannot use sfield in [Serializable] type #1662.asmdef
file template missing underPackages
folders - Assembly Definition File template not available in all places #780