Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "get_unityVersion is not allowed to be called while application is terminating" #979

Merged
merged 2 commits into from
Jan 4, 2019

Conversation

van800
Copy link
Contributor

@van800 van800 commented Jan 4, 2019

Previously RIDER-19688 was fixed by disabling Rider Editor plugin in batch mode, but this fix avoids the same problem by caching unityVersion and thus not trying to get it during AppDomain termination

@van800 van800 self-assigned this Jan 4, 2019
@van800 van800 added this to the Rider 2019.1 milestone Jan 4, 2019
Copy link
Member

@citizenmatt citizenmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@van800 van800 merged commit c6af6e6 into 191 Jan 4, 2019
@van800 van800 deleted the 191-minor-fix branch January 4, 2019 15:11
@citizenmatt citizenmatt added the refactor Internal tasks. Refactor, adding tests, etc. label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Internal tasks. Refactor, adding tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants