Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual openURL method on iOS #990

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ASalavei
Copy link
Contributor

Fixes the following error when calling URIHandler_openUri on iOS 18:

The caller of UIApplication.openURL(_:) needs to migrate to the non-deprecated UIApplication.open(_:options:completionHandler:). Force returning false (NO).

Fixes: https://youtrack.jetbrains.com/issue/CMP-6699

@ASalavei
Copy link
Contributor Author

ASalavei commented Sep 18, 2024

@igordmn , FYI, the bug targeted to 1.7.1

@elijah-semyonov
Copy link
Contributor

Need to build skiko and upgrade version then, it's critical due to apps likely not able to pass submission checks.

@JakeWharton
Copy link

How about deleting this API completely instead? Why does a multiplatform graphics abstraction need to offer an API to open a URL?

@elijah-semyonov
Copy link
Contributor

elijah-semyonov commented Sep 18, 2024

You are absolutely right, it shouldn't be there, it's a forgotten leftover. We fix it first, remove later.

@ASalavei
Copy link
Contributor Author

Good that we spotted it. I believe we will discuss removal soon.
Anyway, the API seems to be going through a deprecation process, and there are some more of them.

@MatkovIvan MatkovIvan merged commit 896ee8d into master Sep 18, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the andrei.salavei/use-actual-openurl branch September 18, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants