Update ID generation in job store entities

Changed ID generation for PausedTriggerGroup and PausedJobGroup by adding 'G' to the formatted string. Also, modified the access modifier of GetId method in Job class to private. In addition, added a new rule - 'MemberCanBePrivate.Global' - to qodana.yaml for code quality checks.
JezhikLaas · Dec 18, 2023 · 8154ad1 · 8154ad1
1 parent a0753ee
commit 8154ad1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/Quartz.Impl.RavenJobStore/Entities/Job.cs b/Quartz.Impl.RavenJobStore/Entities/Job.cs
@@ -22,7 +22,7 @@ public Job(IJobDetail? job, string schedulerInstanceName)
         RequestsRecovery = job.RequestsRecovery;
     }
 
-    public static string GetId(string scheduler, string group, string name) =>
+    private static string GetId(string scheduler, string group, string name) =>
         $"J{scheduler}/{group}/{name}";
 
     [JsonProperty]

diff --git a/Quartz.Impl.RavenJobStore/Entities/PausedJobGroup.cs b/Quartz.Impl.RavenJobStore/Entities/PausedJobGroup.cs
@@ -12,7 +12,7 @@ internal PausedJobGroup(string scheduler, string group)
     }
 
     public static string GetId(string scheduler, string group) =>
-        $"J{scheduler}#{group}";
+        $"JG{scheduler}#{group}";
 
     [JsonProperty]
     public string Id { get; set; }

diff --git a/Quartz.Impl.RavenJobStore/Entities/PausedTriggerGroup.cs b/Quartz.Impl.RavenJobStore/Entities/PausedTriggerGroup.cs
@@ -12,7 +12,7 @@ internal PausedTriggerGroup(string scheduler, string group)
     }
 
     public static string GetId(string scheduler, string group) =>
-        $"T{scheduler}#{group}";
+        $"TG{scheduler}#{group}";
 
     [JsonProperty]
     public string Id { get; set; }

diff --git a/qodana.yaml b/qodana.yaml
@@ -29,3 +29,4 @@ include:
   - name: MemberCanBeMadeStatic.Global
   - name: MemberCanBeMadeStatic.Local
   - name: UnusedParameter.Global
+  - name: MemberCanBePrivate.Global