Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional decomposition test fix (when nrows_blend > 0) (#194) #13

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

JiliDong-NOAA
Copy link
Owner

  • Add missing instance for hailwat

  • Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v.

  • atmosphere.F90 : add hailwat to check
    dyn_core.F90 : Fix from Jun Wang to correct sync of u,v
    fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1

  • Explanatory comment added

  • Removed commented code

  • Clean old code

Description

Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

* Add missing instance for hailwat

* Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v.

* atmosphere.F90 : add hailwat to check
dyn_core.F90 : Fix from Jun Wang to correct sync of u,v
fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1

* Explanatory comment added

* Removed commented code

* Clean old code
@JiliDong-NOAA JiliDong-NOAA merged commit 949ca85 into JiliDong-NOAA:dev/emc Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants