Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes before release v10.1.0 #409

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Murazaki
Copy link
Collaborator

@Murazaki Murazaki commented Jun 9, 2024

Description

Related issues

Should fix #401

  • dynamic tables: give the focus to first input when adding a row
  • fix npm run lint so it can handle lit linting errors
  • fix lit linting errors
  • dynamic table: add titles to "+" and "-" buttons
  • dynamic table: add confirmation when deleting a line
  • channel configuration: add a cancel button that reload data from backend
  • channel emojis: add a cancel button
  • in channel-detail, channel-configuration, ... there are some public attributes prefixed by _, and some private attributes without the prefix. Clean that.
  • _asyncTaskRender: handle error (and pending?) case (this method exists in several elements)
  • check that there is no missing localization for error messages (no hard coded labels)
  • dynamic tables: column description on thead title attribute is not very accessible (does not work on mobile, is not easy to find if user don't know it exists)
  • channel configuration: table too large?

Mandatory Checks

  • I have added a description of the changes in the CHANGELOG files
  • I have run npm run lint to check that my changes respects the coding conventions
  • I have added user documentation for the new features I added
  • I have added technical documentation for the new features I added
  • I added some documentation and I have run npm run doc:translate to generate translations files

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v10.1.0 release: things to fix before release
1 participant