Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.0.1 pw.1 ❗添加遗漏依赖 #15

Merged
merged 3 commits into from
Jan 1, 2024
Merged

V0.0.1 pw.1 ❗添加遗漏依赖 #15

merged 3 commits into from
Jan 1, 2024

Conversation

Johnserf-Seed
Copy link
Owner

[Fixed]

  1. 修复pyproject.toml依赖部分遗漏造成的Error: No such command No such command 'dy' TikTokDownload#623

Copy link

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering. View full project report here.

@@ -81,7 +81,8 @@ def get_command(self, ctx, cmd_name):
logger.info("App: %s" % app_name)
command = getattr(module, app_name)
return command
except (ImportError, AttributeError):
except (ImportError, AttributeError) as e:
logger.error("Error: %s" % e)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.error("Error: %s" % e)
logger.error(f"Error: {e}")

f-string is easier to read, write, and less computationally expensive than legacy string formatting. More details.

@Johnserf-Seed Johnserf-Seed merged commit d28c027 into main Jan 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant