Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show loader until expenditure status is updated #2375

Merged

Conversation

joanna-pagepro
Copy link
Contributor

Description

Showing loader until expenditure status is updated after each step

Testing

  • Step 1. Create a Payment Builder action.
  • Step 2. Get to the Fund step.
  • Step 3. Click and fund the payment and complete the transactions.
  • Step 4. Check if the Fund button will still be clickable.

Diffs

New stuff

Changes 🏗

  • onSuccess prop instead of refetchExpenditure passed to modals and payment step
  • isLoading state added to show loader instead of clickable button on action success
  • strategy: 'fixed' added to UserSelect component, so that the tooltip is visible when inside the table

Deletions ⚰️

  • removed refetchExpenditure from each modal and payment step

TODO

Resolves #2372

@joanna-pagepro joanna-pagepro self-assigned this May 14, 2024
@joanna-pagepro joanna-pagepro requested review from a team as code owners May 14, 2024 12:18
Copy link

@marcocolony marcocolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joanna-pagepro Looks great, working fine now.

Area

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested and working as expected.

Screen.Recording.2024-05-15.at.09.15.27.mov

@joanna-pagepro joanna-pagepro merged commit a0bf681 into feat/advanced-payments-2 May 15, 2024
3 of 4 checks passed
@joanna-pagepro joanna-pagepro deleted the fix/15907590-disable-action-button branch May 15, 2024 08:23
@AdrianDudko AdrianDudko linked an issue May 16, 2024 that may be closed by this pull request
@jakubcolony
Copy link
Collaborator

@joanna-pagepro Please can we ensure all further PRs are merged into feat/advanced-payments-ui as opposed to feat/advanced-payments-2? Thanks

@joanna-pagepro
Copy link
Contributor Author

@jakubcolony this one was merged to feat/advanced-payments-2 because I thought that it was needed before the release and that it shouldn't contain anything that is new on feat/advanced-payments-ui. Sorry if it caused any problems. All future PRs related to advanced payments will be merged to feat/advanced-payments-ui

jakubcolony pushed a commit that referenced this pull request May 22, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jun 7, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jun 10, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jun 17, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jun 17, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jun 25, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jul 12, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jul 18, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Jul 30, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Aug 5, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Aug 6, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Aug 29, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Sep 11, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Sep 26, 2024
…button

fix: show loader until expenditure status is updated
jakubcolony pushed a commit that referenced this pull request Oct 6, 2024
…button

fix: show loader until expenditure status is updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable and show a loading state during transactions
4 participants