-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show loader until expenditure status is updated #2375
fix: show loader until expenditure status is updated #2375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanna-pagepro Looks great, working fine now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tested and working as expected.
Screen.Recording.2024-05-15.at.09.15.27.mov
a0bf681
into
feat/advanced-payments-2
@joanna-pagepro Please can we ensure all further PRs are merged into |
@jakubcolony this one was merged to |
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
…button fix: show loader until expenditure status is updated
Description
Showing loader until expenditure status is updated after each step
Testing
Diffs
New stuff ✨
Changes 🏗
onSuccess
prop instead ofrefetchExpenditure
passed to modals and payment stepisLoading
state added to show loader instead of clickable button on action successstrategy: 'fixed'
added toUserSelect
component, so that the tooltip is visible when inside the tableDeletions ⚰️
refetchExpenditure
from each modal and payment stepTODO
Resolves #2372