-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#2200 allow modifying stake fraction #2386
Feat/#2200 allow modifying stake fraction #2386
Conversation
a0bf681
to
1d5614b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some code snippets to add to
|
9d79c45
to
7e12e5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look and work great, nice job @davecreaser 👍
Considering it's resolving the first part of the issue, would you mind opening another one for the other subtask?
"transaction.ColonyClient.installExtension.title": "Install extension", | ||
"transaction.ColonyClient.installExtension.description": "Install extension", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
@jakubcolony No problem. You mean opening another issue or another PR? |
…take-fraction Feat/#2200 allow modifying stake fraction
…take-fraction Feat/#2200 allow modifying stake fraction
Description
Block ingestor PR here: JoinColony/block-ingestor#223
Ticket here: #2200
Testing
Create a fake UI to trigger the saga, and trigger it. The stake fraction for the staked expenditure extension should be updated in the db.
Diffs
New stuff ✨
Contributes to #2200