Change how extensions receive tokens and reputation #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once #971 is merged, however, we can support this, as we can do a lookup from extension address to colony. I would suggest we merge the feature as-is and update it once #971 is complete. |
area
force-pushed
the
feat/no-extension-reputation
branch
from
9df1fc6
to
059abe4
Compare
area
force-pushed
the
feat/no-extension-reputation
branch
from
059abe4
to
cf8ec37
Compare
kronosapiens
previously approved these changes
Sep 23, 2021
|
Using superpowers to merge this. If you have a problem with my last commit @kronosapiens then bring it up with me, but in another PR 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #991 (when it's done).
Currently, this just has some failing tests!