Comply to NC 18+

[DecaTec]

The app needs to be changed due to changes in NC 18 (share API), see nextcloud/server#15719 and nextcloud/socialsharing@931efc9.

[elpraga]

It would be great if it were made compatible with NC18!

[small1]

Just tried to enable it anyway on nc18 and it does not work.

[DecaTec]

Yes, it cannot work as the whole share UI was redesigned in NC 18.
Unfortunately, I cannot tell you when I can provide an update of the app.

Any PRs are welcome. 😄

[elpraga]

That is sad to hear. Unfortunately, I cannot contribute with any PRs.

Sincerely, I do not understand why this app isn't part of the official release.

[elpraga]

I've just noticed that my previous comment came across a bit harsh.. That was not my intention. I cannot contribute, because I do not know how to code, I'm an English teacher.

Thank you for your work! I hope you find time to patch the app soon :)

[DecaTec]

No offense taken. 😃

Will try to supply a patch soon.

[codywarmbo]

Incredibly useful app extension. I also agree that NC should include this as a default! I am considering reverting my entire NC setup back to 17 purely for this function...

[adx442]

Incredibly useful app extension. I also agree that NC should include this as a default! I am considering reverting my entire NC setup back to 17 purely for this function...

I'm really grateful that previously renamed shares still work in 18 (like my one-way upload folder and some installers that I always send to clients). DecaTec, I can't help with a PR, but thanks for continuing to work on it. I miss this functionality in NC every day since 18!

[Ecphrasis]

Yes, I really miss this feature too ! Should be official for sure !
Thanks a lot for this, and I hope to use it again soon !

[morevnaproject]

Any chance to get this solved soon? ^__^

[DecaTec]

I'm working on it, but I'm struggling a but with vue.

[elpraga]

Thank you @DecaTec !

[walterzilla]

This app is gold, thank you @DecaTec for your effort!

[stalkerGH]

Yes, I confirm superb words from other users and waiting for new version of plugin for NC 18 too.

[linuxmangr]

YES Is Very useful plugin my users need it! And I wait new version.

[poltrian]

it would be great if it worked for 18 too. Thanks for your great work

[stephanedupont]

Thank you for your work, this is an absolutely vital extension. Fortunately, I saw this before updating Nextcloud, so now I'm waiting for a compatible version before updating from 17.x to 18.x.

[FelixBuehler]

Would be very grateful too. Want to update my NC to v18, but I have many shares with customized URL.

[DecaTec]

Update:
It will take longer as expected, because on NC 18 there are only limited possibilities to extend the details/share menu. I think that I'll need an extension of NC's API first. I'm already in contact with the NC devs.

[elpraga]

Is there a way to support the idea of including the app into Nextcloud?
And, more importantly, would you be interested in doing so @DecaTec ?

[DecaTec]

This was already suggested several times.
But the use of the app can lead to a security risk (links might be guessable). Due to this fact, this app will never become "official".

[szaimen]

@DecaTec I mean imho it could become "official" if you would be able to force password protection if a URL is changed with the sharerenamer... (maybe force password protection should also be the default setting if you use the sharerenamer?)

[elpraga]

I don't think that would be desirable @szaimen There are use case in which using a password is not needed or desired. I believe it should remain up to the admin to decide.

[adx442]

I don't think that would be desirable @szaimen There are use case in which using a password is not needed or desired. I believe it should remain up to the admin to decide.

I think what he's implying is that by adding the option for password protection, it might get it past the Nextcloud gatekeepers. However, that functionality was already in the past versions. I agree, though, I certainly don't want mandatory password protection with renamed links. I've always used it for things like sending someone service files, like https://nc.example.com/s/Teamviewer so it's clear what it is and easy for me to remember and just write in an e-mail without going back to the server to copy the link.

[jficz]

But the use of the app can lead to a security risk (links might be guessable).

Wait, seriously? You're saying someone actually considers random links a "security feature"?

[szaimen]

I don't think that would be desirable @szaimen There are use case in which using a password is not needed or desired. I believe it should remain up to the admin to decide.

I think what he's implying is that by adding the option for password protection, it might get it past the Nextcloud gatekeepers. However, that functionality was already in the past versions. I agree, though, I certainly don't want mandatory password protection with renamed links. I've always used it for things like sending someone service files, like https://nc.example.com/s/Teamviewer so it's clear what it is and easy for me to remember and just write in an e-mail without going back to the server to copy the link.

No, I just wanted to suggest the option to add a configurable share-setting to the admin settings, where the admin can decide what happens with shares that got renamed. I imagine 3 options:

1. Enforce password protection
2. Always ask for a password
3. Disable password protection

I think that this feature would allow the nextcloud team to make this app official.

[adx442]

What I was mentioning before is that Password protection already worked with renamed links in the past, it doesn't need to be duplicated in the renamer.

[Greek64]

I have to agree with @cptMikky.
Although it is "harder" to guess a random link, this is in no way a security feature, and should in no way be seen as such.
For all practical purposes a random generated link should be treated the same as a custom named link.
If you need protection, that's what the password protection is for (and the password policy enforcer).

If one opens a issue to re-discuss the integration of this app to nextcloud, give me a heads up to cast my vote.

[szaimen]

What I was mentioning before is that Password protection already worked with renamed links in the past, it doesn't need to be duplicated in the renamer.

But I really think that there should be a different setting to "normal" links.
E.g. what if you rename your share to just
https://nc.example.com/s/a
Then it is definitely much less secure than a random share.

[szaimen]

There is now an api which makes it possible to inject entries into the share dropdown:
nextcloud/server#28835
It will be available in NC23 and NC22.2.0

[gaellafond]

It will be available in NC23 and NC22.2.0

I download the files_downloadlimit app, compiled it, install it and when I tried to enable it, NextCloud said it was for NC 23. I'm so disappointed. I guess I will have to try the latest version now...

[szaimen]

Please report this to the correct repo (it shall work on NC22 in the future, too) Thanks!

[JonathanTreffler]

There is now an api which makes it possible to inject entries into the share dropdown:
nextcloud/server#28835
It will be available in NC23 and NC22.2.0

Wow, cool

[JonathanTreffler]

First we need to get the NC 20-22 compatible version of this app out there, but after that we could drop support for NC 20-21 and implement it with the new API.

[Memphizzz]

Any news on this?

[gaellafond]

@Memphizzz JonathanTreffler created a working version of the app. I think it's only waiting approval. A few Lint tests are still failing.

To install the plugin (assuming you do not want to compile it):
Download it from here:
https://github.com/JonathanTreffler/sharerenamer/files/7216628/sharerenamer.zip

The code is available in branch "v3". See pull requests for more info:
#31 (comment)

[JonathanTreffler]

@Memphizzz JonathanTreffler created a working version of the app. I think it's only waiting approval. A few Lint tests are still failing.

The limiting factor is my time right now. The only things left to do is request a new certificate for the nextcloud app store and upload it there. Sadly I can't give an ETA right now, but it is very easy to manually install the v3 version, so nobody has to wait until it is pushed to the appstore.

[julpec]

I can't get the application to work. I am under Nextcloud version 22.2.2 and I install with this procedure :

cd /var/www/nextcloud/apps
git clone https://github.com/JonathanTreffler/sharerenamer/
cd sharerenamer
git checkout v3
cd .. && chown -R www-data:www-data sharerenamer

After that, I activate the application in the administration interface. After that, I have no reference to the renaming of the public link.
Did I make a mistake? Or I didn't understand if the app in v3 was now compatible with NC22. The thread is not very clear about this.

Thanks

[JonathanTreffler]

I can't get the application to work. I am under Nextcloud version 22.2.2 and I install with this procedure :

cd /var/www/nextcloud/apps
git clone https://github.com/JonathanTreffler/sharerenamer/
cd sharerenamer
git checkout v3
cd .. && chown -R www-data:www-data sharerenamer

After that, I activate the application in the administration interface. After that, I have no reference to the renaming of the public link. Did I make a mistake? Or I didn't understand if the app in v3 was now compatible with NC22. The thread is not very clear about this.

Thanks

You need to compile it first. I would recommend downloading the zip file mentioned in this issue, which contains a compiled pre release.

[julpec]

Very well, thank you.
So, this section must be modified in the readme.
Also, it doesn't work. I extracted the .zip in apps/sharerenamer but still no visible features after activation of the app.

[JonathanTreffler]

Have you looked in the share tab or in the sharerenamer tab ? (Previously the sharerenamer app injected itself into the share tab, it now has its own tab)

[JonathanTreffler]

@DecaTec I need your help to transfer the apps permission on the AppStore: https://nextcloudappstore.readthedocs.io/en/latest/developer.html#transferring-your-app-to-a-new-owner

Can you please unlock sharerenamer ?
I have already applied for a new certificate in nextcloud/app-certificate-requests#478.

[julpec]

Unfortunately, on a NC server v21, there is no specific tab of the application, nor any entry related to this application that I can detect
BUT, on a NC v22 server I can see this tab and I can rename my share !
However, I noticed a small flaw in the functionality. When you create a public share, you can't rename it right away. You have to reload the page to have access to the modification in the sharerenamer tab.
In conclusion, it works on a v22 server, sharerenamer have his own tab, but it is not possible to rename on the fly.

[JonathanTreffler]

Ok, I will then only release it for Nextcloud 22.
With Nextcloud 23 already out I don't have the time to fix it in 21.
Thanks for looking into it.

[JonathanTreffler]

I just tested it in Nextcloud 23 and it worked :)
So the release (which I hope to release in the next days) will include support for Nextcloud 22 and 23.

[JonathanTreffler]

This got automatically closed, because I merged the pull request, but I am going to open it until the release for the app store is done.

[jshatch]

I just tried the pre-release zip and it works. If you create a new share on a file the new share doesn't show up in the rename list until you close and reopen the sidebar. Same thing with renaming a share, the new share name does not reflect in the link on the sharing tab until the sidebar is closed and reopened. Maybe not a critical issue, but something to be aware of.

[JonathanTreffler]

I just tried the pre-release zip and it works. If you create a new share on a file the new share doesn't show up in the rename list until you close and reopen the sidebar. Same thing with renaming a share, the new share name does not reflect in the link on the sharing tab until the sidebar is closed and reopened. Maybe not a critical issue, but something to be aware of.

I am aware of that, it is something I will address in a later release. Right now I just want to get the update out as fast as possible :)

[JonathanTreffler]

Good News:
I have gotten a certificate from Nextcloud and the ownership of the app in the app store has been transferred to me, which means there's nothing standing in the way of releasing v3 to the app store 🎉🎉🎉🎉🎉🎉🎉🎉

Tomorrow I will update the README and all the descriptions and release v3 to the app store.

Thanks for your patience and thanks to everyone, who tried the "alpha" release.

[JonathanTreffler]

New Screenshots :)

[DecaTec]

This is great news!
Thanks a lot for your efforts!
Looking forward for the app being released on the NC app store soon.

[JonathanTreffler]

The v3.0.0 release is signed and published on Github 🎉

I will now upload the release to the Nextcloud app store. I don't know if that will take time to process, but I will post here, once it can be downloaded through the store.

[JonathanTreffler]

Version 3.0.0 can now be downloaded through the app store :)

At least for me the app does not appear in the list of apps in the app store inside a nextcloud instance, but since it can be downloaded from the appstore website it should only be a matter of time.

[JonathanTreffler]

In my nextcloud instance sharerenamer is now in the app store list :)
I will close this now.