Version 3 Rewrite

[JonathanTreffler]

implements #21

Todo

• Implement boilerplate code for sidebar

• implement sidebar loader

• call Sidebar loader

• install necessary dependencies (vuejs, webpack)

• add webpack configuration

• add build scripts

• Add functionality to sidebar

• Styling

• Final Testing

[DecaTec]

Can we merge this or should we wait until all the todos are done?

[JonathanTreffler]

Since it is not ready to be published to the app store, i think we should keep it in this branch and keep master stable.

[DecaTec]

OK, then we don't merge (yet).

Have you received my mail? 😉

[gaellafond]

I can confirm what RiCkYB-667 said: the latest v3 commit is not working for me either. My old modified version is still working, so I can use it to compare with the v3 branch to see what is different. I will spend some time on it tomorrow and hopefully find out what need to be done to make it work with NC 21.

[RiCkYB-667]

I can confirm what RiCkYB-667 said: the latest v3 commit is not working for me either. My old modified version is still working, so I can use it to compare with the v3 branch to see what is different. I will spend some time on it tomorrow and hopefully find out what need to be done to make it work with NC 21.

Hey there @gaellafond !
Did you by any chance manage to find the errors?
It would be nice to know what's up! ;)
Would really love to be able to rename those pesky links...
Also should you be able to share your working version until this finalizes, i would be grateful!

Thank you!

[gaellafond]

@RiCkYB-667 Sorry for late reply. I'm currently spending some time looking at it. I'm comparing my working version with the latest commit from this branch, but I don't quite understand what prevent this one from working. The structure is very different, but the code looks the same. I believe the code needs to be compiled in a very specific way and I don't know the process.

The sharerenamer app have another big issue for us. The shares are limited to 32 characters due to DB field limitation. We could increase the field size, but changing the DB schema is risky. Future NextCloud updates could revert the schema, which would cause shared links to fail.

We are planning to implement our own app. The idea, at this point, is to create some sort of "Proxy". Instead of changing the share in the DB, we will add a public API which redirect the named link to the shared hash URL.

[JonathanTreffler]

@RiCkYB-667 Sorry for late reply. I'm currently spending some time looking at it. I'm comparing my working version with the latest commit from this branch, but I don't quite understand what prevent this one from working. The structure is very different, but the code looks the same. I believe the code needs to be compiled in a very specific way and I don't know the process.

The compilation process Is quite simple. Just run:
npm ci
and then
npm run build

Here's a compiled version of the latest commit of this PR ready to go: sharerenamer.zip

That is probably the reason why the testing on NC21 didn't work for anyone but me. The last zip i provided you all for testing was compiled, but after @gaellafond 's testing i didn't create another compiled release.

[gaellafond]

Thank you very much @JonathanTreffler . I must be doing something wrong. I pull the latest version of the project and re-compiled it / redeployed it again this morning, but still no success. I tried your pre-compiled version and it's working. I compared the version I compiled (found in sharerenamer/build/artifacts/sign/sharerenamer) with the version you provided and they are completely different. Pretty much none of the files in your build are in my build.

I assumed the compiler was not actually doing anything so I manually deleted the build folder and recompiled it. It didn't trigger any compile error but the build folder was not recreated.

So, I still don't understand the build process. What is the "npm run build" supposed to do? Where should the compiled version be after compilation? Where is the "build" folder coming from? (It's not on Git, so I assume it was created from one of my numerous attempts at building the project...)

I assume most of those questions are standard knowledge for NextCloud, or even npm. I have very little experience with those at the moment. I need deeper explanations.

[gaellafond]

I tried to run "make all" but it ended with an error:
make: *** No rule to make target 'test', needed by 'all'. Stop.

I edited the Makefile. There is indeed no "test" defined in the file, so I assume the "all" goal is not part of the build process otherwise you would have fixed it. Nonetheless, I removed the "test" at the end of the "all" goal and re-run the "make all" command. It completed without errors, but the build folder is still not re-created.

[gaellafond]

I managed to get it to work. Here is what I did:

$ git clone https://github.com/JonathanTreffler/sharerenamer.git
$ cd sharerenamer/
$ git checkout v3
$ npm ci
$ npm run build
$ rm -R node_modules

Then I deploy the whole project folder to NextCloud apps folder.

Usually, when you compile a project, it generates a deployable artifact. I was not expecting to have to deploy the whole project. I deleted the node_modules folder because it was not in the build you provided, and because it was very big (~150MB).

My artifact do not have the "vendor" folder yours have. I assume that's not important.

[JonathanTreffler]

My artifact do not have the "vendor" folder yours have. I assume that's not important.

Yes, i just did a fast release for testing. For an actual release the vendor folder would be removed (because nextcloud will download the libraries in it automatically).

[JonathanTreffler]

I managed to get it to work. Here is what I did:

$ git clone https://github.com/JonathanTreffler/sharerenamer.git
$ cd sharerenamer/
$ git checkout v3
$ npm ci
$ npm run build
$ rm -R node_modules

Then I deploy the whole project folder to NextCloud apps folder.

Usually, when you compile a project, it generates a deployable artifact. I was not expecting to have to deploy the whole project. I deleted the node_modules folder because it was not in the build you provided, and because it was very big (~150MB).

That is exactly the correct way :)

[JonathanTreffler]

I probably never adjusted the Makefile for v3. I will look into it.

[JonathanTreffler]

Usually, when you compile a project, it generates a deployable artifact. I was not expecting to have to deploy the whole project.

Yes it compiles the js and vue files from src with the libraries from node_modules (installed by npm ci) and outputs to js/. It doesn't do anything with the php code, so you need to deploy the full folder structure.

[gaellafond]

Thanks @JonathanTreffler for taking the time to answer all my questions.
In the master branch, it creates a .tar.gz file in the build folder then it sign the archive using a private key (which is obviously not in the project sources). At least, that's how I understand the Makefile. Is that an old practice for old version of NextCloud? Will you have to implement something similar for NextCloud 20+?

[JonathanTreffler]

I will need to figure that out. It is still the principle, but lately everything has been automated with github actions. I will need to get a new key for the appstore (because of the owner transfer), which should not be a problem.

[JonathanTreffler]

Finally all checks pass, so this can be merged :)