contrib/icinga2: harmonize Icinga 2 config w/ ITL #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While fixing the outdated command name in the Icinga 2 ITL[0], it was suggested to support the newer command line options there as well. To synchronize or harmonize the ITL definition and the CheckCommand shipped here, I made small changes to not break the ITL, as I would guess that more people are using the ITL definition instead of the shipped command.conf from here. The breaking changes were added to the CHANGELOG. [0]: Icinga/icinga2#10035
oxzi
added a commit
to Icinga/icinga2
that referenced
this pull request
May 8, 2024
Harmonize the arguments with the upstream CheckCommand[0], including a patch to use the ITL variables[1]. [0]: https://github.com/Josef-Friedrich/check_systemd/blob/main/contrib/icinga2/command.conf [1]: Josef-Friedrich/check_systemd#38 Co-Authored-By: RincewindsHat <[email protected]>
|
Thank you very much! |
oxzi
added a commit
to Icinga/icinga2
that referenced
this pull request
Sep 5, 2024
Harmonize the arguments with the upstream CheckCommand[0], including a patch to use the ITL variables[1]. [0]: https://github.com/Josef-Friedrich/check_systemd/blob/main/contrib/icinga2/command.conf [1]: Josef-Friedrich/check_systemd#38 Co-Authored-By: RincewindsHat <[email protected]>
oxzi
added a commit
to Icinga/icinga2
that referenced
this pull request
Sep 6, 2024
Harmonize the arguments with the upstream CheckCommand[0], including a patch to use the ITL variables[1]. [0]: https://github.com/Josef-Friedrich/check_systemd/blob/main/contrib/icinga2/command.conf [1]: Josef-Friedrich/check_systemd#38 Co-Authored-By: RincewindsHat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing the outdated command name in the Icinga 2 ITL1, it was suggested to support the newer command line options there as well.
To synchronize or harmonize the ITL definition and the CheckCommand shipped here, I made small changes to not break the ITL, as I would guess that more people are using the ITL definition instead of the shipped command.conf from here.
The breaking changes were added to the CHANGELOG.
Footnotes
https://github.com/Icinga/icinga2/pull/10035 ↩