Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Rename *:test to test:* #786

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 4, 2023 · 3 comments · Fixed by #811
Closed
3 tasks done

🛠 Tooling: Rename *:test to test:* #786

JoshuaKGoldberg opened this issue Sep 4, 2023 · 3 comments · Fixed by #811
Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, "end-to-end" tests are named in package.json like specifier:test:

create-typescript-app/package.json

Line 26 in f9d63fc

"create:test": "node script/create-test-e2e.js",

But the rest of the scripts generally adhere to a format like area:specifier, like:

create-typescript-app/package.json

Line 32 in f9d63fc

"lint:knip": "knip",

Let's switch them to test:create, test:initialize, and test:migrate.

Additional Info

You'll want to do a full text search on :test. At least package.json and some .github/workflows/*.yml files will need to be changed, as well as .github/DEVELOPMENT.md. And there should be at least one .ts file.
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Sep 4, 2023
@DanexQ
Copy link
Contributor

DanexQ commented Sep 6, 2023

Can I work on this one?

@JoshuaKGoldberg
Copy link
Owner Author

For sure! See https://github.com/JoshuaKGoldberg/create-typescript-app/blob/b96c7b35946770f7b760c6a0afa67cdf105cf24a/.github/CONTRIBUTING.md#issue-claiming: no need to claim an issue, just sent a PR 🚀

@DanexQ DanexQ mentioned this issue Sep 6, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 7, 2023
@DanexQ @JoshuaKGoldberg
build: renamed *:test to test:* in every file (#811)
486f89d 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #786
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview
Also fixed a typo "initiamigratelize" in
.github/workflows/DEVELOPMENT.md.
<!-- Description of what is changed and how the code change does that.
-->

---------

Co-authored-by: Josh Goldberg <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🎉 This is included in version v1.29.37 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: renamed *:test to test:* in every file DanexQ/create-typescript-app
2 participants
@JoshuaKGoldberg @DanexQ