Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Switch from npm-package-json-lint to eslint-plugin-package-json #839

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 19, 2023 · 3 comments · Fixed by #1269
Closed
3 tasks done

🚀 Feature: Switch from npm-package-json-lint to eslint-plugin-package-json #839

JoshuaKGoldberg opened this issue Sep 19, 2023 · 3 comments · Fixed by #1269
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
General Simplific...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Splitting out of #834: I'd like to reduce the number of linters and scripts used in this project. I recently started working on eslint-plugin-package-json. I hope to get it to be a reasonable replacement for npm-package-json-lint.

Additional Info

Blocked on eslint-plugin-package-json getting to feature parity with npm-package-json-lint. Currently tracked in JoshuaKGoldberg/eslint-plugin-package-json#28; will be split out soon.
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: blocked Waiting for something else to be resolved labels Sep 19, 2023
This was referenced Sep 19, 2023
Open
Closed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 6, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Jan 20, 2024 •
edited
Loading

I'm getting pretty close on the eslint-plugin-package-json end. https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/milestone/1 tracks it having a fleshed out initial recommended config. Once that milestone is mostly done, I'll switch over here.

There are a few require-* style rules from npm-package-json-lint not captured by that milestone, but that's ok. I think they're not the most impactful rules for what this template goes for.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Open
@JoshuaKGoldberg
Copy link
Owner Author

Per JoshuaKGoldberg/eslint-plugin-package-json#42 (comment), this is now unblocked. Hooray! 🙌

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@JoshuaKGoldberg
feat: onboard eslint-plugin-package-json (#1269)
592b0c8 
## PR Checklist

- [x] Addresses an existing open issue: fixes #839
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Directly swaps from the standalone `npm-package-json-lint` linter to
using `eslint-plugin-package-json` in the existing ESLint config. Fewer
tools, yay!
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.56.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
General Simplification
Development

Successfully merging a pull request may close this issue.

feat: onboard eslint-plugin-package-json JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg