Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefixes and cleans unused strings #270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prefixes and cleans unused strings #270

wants to merge 2 commits into from

Conversation

RafalOzogJudopay
Copy link
Contributor

  1. All strings has been prefixed with 'jp_', including those non-translatable. Although they can't be translated, I have checked myself that still could be overriden accidentally. Therefore I have prefixed them as well.
  2. Unused strings has been removed.
  3. All changes other than in strings.xml has been performed automatically by Android Studio (when renaming strings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-tudor stefan-tudor stefan-tudor approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RafalOzogJudopay @stefan-tudor