Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jsbin link #3

Open
tomalec opened this issue Jan 5, 2017 · 6 comments
Open

Update jsbin link #3

tomalec opened this issue Jan 5, 2017 · 6 comments
Milestone
UNIS Juicy elemen...

Comments

@tomalec
Copy link
Member

tomalec commented Jan 5, 2017

Steps to reproduce

Open any new issue in any Juicy repo or .issue_template

Actual result

link to JSBin has Hardcoded version https://jsbin.com/ligimo/3/edit?html,output
and the version there points to master branch of a component, which sometimes does not exist.

I'd suggest changing it to https://jsbin.com/ligimo/edit?html,output so we could update the jsbin without changing all issue templates.

@warpech WDYT?
@warpech
Copy link

warpech commented Jan 5, 2017

link to JSBin has Hardcoded version https://jsbin.com/ligimo/3/edit?html,output
and the version there points to master branch of a component, which sometimes does not exist.

Maybe we should fix this and decide on consistent branching?

I'd suggest changing it to https://jsbin.com/ligimo/edit?html,output so we could update the jsbin without changing all issue templates.

Good point.

@tomalec
Copy link
Member Author

tomalec commented Jan 5, 2017

Maybe we should fix this and decide on consistent branching?

I think we already agreed on gh-pages as default brnach, to keep single branch for development and demos. That's why I set it at https://jsbin.com/ligimo/edit?html,output (rev.6)

@warpech
Copy link

warpech commented Jan 8, 2017 •
edited
Loading

Actually in GitHub now we can choose the branch that is used for GitHub Pages. So I would vote to use master everywhere and remove gh-pages everywhere, too.

See: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/

@tomalec
Copy link
Member Author

tomalec commented Jan 9, 2017

Wow, I was not aware of it, it's great, let's do so!

@warpech
Copy link

warpech commented Jan 9, 2017

Wow, I was not aware of it, it's great, let's do so!

I have made a single umbrella issue about this: https://github.com/Starcounter/AdminTrack/issues/202

Also, if I understand correctly, it is possible to make something like "branch aliases" in Git: http://stackoverflow.com/questions/14365946/git-branch-alias

But I would rather not do it - too much confusion.

warpech added a commit to Juicy/juicy-polymer-boilerplate that referenced this issue Jan 18, 2017
@warpech
change gh-pages branch to master (Starcounter/AdminTrack#202, Juicy/j…
eaaccd3 
…uicy-element-boilerplate#3)

update README.md
remove branch-specific Travis config, as it is not needed anymore
warpech added a commit that referenced this issue Jan 18, 2017
@warpech
change gh-pages branch to master (Starcounter/AdminTrack#202, #3)
70ce75a 
update README.md
remove branch-specific Travis config, as it is not needed anymore
@warpech
Copy link

warpech commented Jan 18, 2017

https://github.com/Starcounter/AdminTrack/issues/202 is now done. gh-pages branch should not be used anymore.

The second part of this issue is not done yet, but I agree with it:

I'd suggest changing it to https://jsbin.com/ligimo/edit?html,output so we could update the jsbin without changing all issue templates.

@warpech warpech added this to the Juicy elements support milestone Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
UNIS Juicy elements support
Development

No branches or pull requests
2 participants
@tomalec @warpech