Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always render caption-text (even with empty opts) #20

Merged
merged 2 commits into from
Mar 5, 2018

Conversation

alshakero
Copy link
Contributor

@alshakero alshakero commented Mar 2, 2018

It shouldn't have any side-effects since generateOptions checks for options.length internally.

if (!this.options || !this.options.length) {
return;
}

Fixes: https://github.com/Starcounter/Blending/issues/99#issuecomment-369909521

@alshakero alshakero requested a review from warpech March 2, 2018 13:38
Copy link

@kegor kegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, checked on a running application:
image

Copy link
Contributor

@warpech warpech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Could you pls add a test for it?

@alshakero alshakero merged commit 0a52d87 into master Mar 5, 2018
@alshakero
Copy link
Contributor Author

It's insane how everytime I only remember to push the version commit to the branch instantly after I merge it 😢

@alshakero alshakero deleted the always-show-caption branch March 5, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants