Enhancement of BinaryThresholdPredictor to handle outlier detection models #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #399 and:
BinaryThresholdPredictor
, so as to include new outlier detector types added to MLJModelInterface here.wrapped_model
tomodel
, for consistency with the wrappersTunedModel
andIteratedModel
. I haven't kept backwards compatibility as a I don't think this is going to effect many users yet, but I am tagging the release as minor (breaking). @OkonSamuel may want to comment.Actually, it is impossible for a correctly implemented probalistic classifier to predict
UnivariateFinite
having a different number of classes from the target on which it was trained, because the pool of theUnivariateFinite
should always coincide with the pool of the target on which the model was trained and resampling does not effect the pool of the training target, as in this example:cc @davnn
@OkonSamuel Be great if you can have a look over this. Do you when you might get a chance, assuming your'e willing?