introduce function collect_as for construction from an iterator
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
commented
Apr 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 98.91% 98.36% -0.56%
==========================================
Files 1 1
Lines 92 183 +91
==========================================
+ Hits 91 180 +89
- Misses 1 3 +2 ☔ View full report in Codecov by Sentry. |
Makes constructing `FixedSizeArray`s more convenient! Inspired by JuliaLang/julia#36288 This currently ignores `Base.IteratorElType`, xref https://discourse.julialang.org/t/i-dont-get-base-iteratoreltype/113604 The allocations in some code paths are probably excessive/could be optimized. But I guess this is good for a start. Fixes #20
giordano
reviewed
Apr 30, 2024
One of these wasn't being recorded by code coverage (another Julia coverage bug, I guess).
giordano
reviewed
May 1, 2024
| @@ -94,6 +96,41 @@ end | |||
|
|
|||
| # helper functions | |||
|
|
|||
| dimension_count_of(::Base.SizeUnknown) = 1 | |||
| dimension_count_of(::Base.HasLength) = 1 | |||
There was a problem hiding this comment.
Last line still not covered (unless it's another coverage bug?)
There was a problem hiding this comment.
Yeah, it's JuliaLang/julia#54214 again. I guess this form is buggy:
f(::SingletonType) = isbits_literalThere was a problem hiding this comment.
So it isn't just empty tuple but any singleton?
There was a problem hiding this comment.
I did check that these lines are in actuality covered by the tests, by replacing 1 with error().
giordano
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes constructing
FixedSizeArrays more convenient!Inspired by
JuliaLang/julia#36288
This currently ignores
Base.IteratorElType, xref https://discourse.julialang.org/t/i-dont-get-base-iteratoreltype/113604The allocations in some code paths are probably excessive/could be optimized. But I guess this is good for a start.
Fixes #20