Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to staticarrays.construct_sametype #23

Closed
wants to merge 1 commit into from

Conversation

nlw0
Copy link

@nlw0 nlw0 commented Aug 20, 2020

No idea what that function does, I have HybridArrays as a dependency, this is breaking compilation right now, and simply removing was fine. Should we perhaps pin down the appropriate version of StaticArrays?... Or is this actually something that can really be removed?

@mateuszbaran
Copy link
Collaborator

Apparently removing this line breaks something in HybridArrays. This is part of the SSubArray code which I will remove when a version of StaticArrays with this: JuliaArrays/StaticArrays.jl#783 merged is tagged. Alternatively I could add sized abstract arrays to HybridArrays for now. How exactly are these two lines breaking your code?

Should we perhaps pin down the appropriate version of StaticArrays?

HybridArrays already works with only one specific version of StaticArrays (0.12.4 currently).

@mateuszbaran
Copy link
Collaborator

@nlw0 Did you manage to solve your problem?

@nlw0
Copy link
Author

nlw0 commented Sep 14, 2020

Sorry, I could never take another look at this. If the change in StaticArrays can fix this I'm happy. I have actually stopped using the package for now due to another issue related to ._pointer... Will try again once I have my project in better "shape".

@mateuszbaran
Copy link
Collaborator

FYI, #25 solves this problem but requires StaticArrays.jl master so it waits until a new breaking release of StaticArrays is tagged.

@mateuszbaran
Copy link
Collaborator

StaticArrays.jl 1.0 was tagged, so I merged #25 and tagged HybridArrays.jl 0.4.0 that doesn't have these methods. Let know if it doesn't work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants