Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support matrix multiplication (Continue #93) #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support matrix multiplication (Continue #93) #146

wants to merge 2 commits into from

Commits on Sep 15, 2020

  1. Preliminary support for matrix multiplication. 

    - New methods for * for combinations of OffsetArray and AbstractArray
  Unfortunately this introduces method ambiguities with Base.
- As an alternative, tried defining a new promote_rule, but somehow it doesn't get invoked.

New convenience constructors
- Wrap any (non-offset) array as an OffsetArray with standard indices
- Remove layer of indirection when constructing with explicit offsets

Cosmetic edits to constructor section for improved readability
    @jishnub
    Ryan Bennink authored and jishnub committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    f34598c View commit details
    Browse the repository at this point in the history

  2. use offsets instead of axes

    @jishnub
    jishnub committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    0529fe8 View commit details
    Browse the repository at this point in the history