Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated action versions #125

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/Documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ jobs:
document:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@latest
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: '1.6'
- uses: julia-actions/julia-docdeploy@releases/v1
version: 1
- uses: julia-actions/julia-docdeploy@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8 changes: 4 additions & 4 deletions .github/workflows/Tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
jobs:
test:
timeout-minutes: 30
name: ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }}
name: ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -29,13 +29,13 @@ jobs:
- x86

steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v1
- uses: codecov/codecov-action@v4
with:
file: lcov.info
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ coverage
deps/usr/lib/pa_shim.so
deps/usr/lib/pa_shim.dylib
deps/usr/lib/pa_shim.dll
.DS_Store
LocalPreferences.toml
Manifest.toml
settings.json
1 change: 1 addition & 0 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Suppressor = "fd094767-a336-5f1f-9728-57cf17d0bbfb"
julia = "1.6"
alsa_plugins_jll = "1.2.2"
libportaudio_jll = "19.6.0"
LinearAlgebra = "1"
SampledSignals = "2.1.1"
Suppressor = "0.2"

Expand Down
12 changes: 6 additions & 6 deletions examples/lilyplay.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function paudio()
devs = PortAudio.devices()
if DEFAULTDEVICE < 0
devnum = findfirst(x -> x.maxoutchans > 0, devs)
(devnum == nothing) && error("No output device for audio found")
(devnum === nothing) && error("No output device for audio found")
else
devnum = DEFAULTDEVICE + 1
end
Expand Down Expand Up @@ -43,19 +43,19 @@ end

function parsevoice(melody::String; tempo = 132, beatunit = 4, lyrics = nothing)
ostream = paudio() # initialize audio for output
lyrics_syllables = lyrics == nothing ? nothing : split(lyrics)
lyrics_syllables != nothing && (lyrics_syllables[end] *= "\n")
lyrics_syllables = lyrics === nothing ? nothing : split(lyrics)
lyrics_syllables !== nothing && (lyrics_syllables[end] *= "\n")
note_idx = 1
oldduration = 4
for line in split(melody, '\n')
percent_idx = findfirst('%', line) # Trim comment
percent_idx == nothing || (line = line[1:(percent_idx - 1)])
percent_idx === nothing || (line = line[1:(percent_idx - 1)])
for token in split(line)
pitch, duration, dotted, sustained = parsetoken(token)
duration == nothing && (duration = oldduration)
duration === nothing && (duration = oldduration)
oldduration = duration
dotted && (duration *= 1.5)
if lyrics_syllables != nothing && 1 <= note_idx <= length(lyrics_syllables)
if lyrics_syllables !== nothing && 1 <= note_idx <= length(lyrics_syllables)
# Print the lyrics, omitting hyphens
if lyrics_syllables[note_idx][end] == '-'
print(join(split(lyrics_syllables[note_idx][:], "")[1:(end - 1)]), "")
Expand Down