Add benchmarks for map and broadcast with Union{T, Missing} arrays #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These will either need to be behind a version guard or we'll need to introduce a dependency on Missings for 0.6 support. |
|
Ah, indeed. I've reverted the move to |
Add benchmarks comparing a simple loop with map() and broadcast().
nalimilan
commented
Feb 1, 2018
| g["perf_sum", string(typeof(A))] = @benchmarkable perf_sum($A) | ||
| g["perf_countnothing", string(typeof(A))] = @benchmarkable perf_countnothing($A) | ||
| for (M, A) in ((false, X), (true, X2)) | ||
| g["perf_sum", T, M] = @benchmarkable perf_sum($A) |
There was a problem hiding this comment.
I wasn't sure how the benchmarks names work: is it OK to use three dimensions and to use values directly rather than strings?
There was a problem hiding this comment.
Yes, you can use arbitrary tuples of values for benchmark keys
There was a problem hiding this comment.
the main guideline is to keep them relatively short - long keys are formatted annoyingly in benchmark reports
|
Good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks comparing a simple loop with
mapandbroadcast. Usemissinginstead ofnothingsince it propagates with standard operations, which allows testing more cases.These are the benchmarks associated with JuliaLang/julia#25828.