Check DISABLE_AMEND_COVERAGE_FROM_SRC env var #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/DISABLE_AMEND_COVERAGE_FROM_SRC
branch
3 times, most recently
from
9ecaaff
to
6cc4d61
Compare
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 80.18% 80.23% +0.05%
==========================================
Files 6 6
Lines 333 334 +1
==========================================
+ Hits 267 268 +1
Misses 66 66
Continue to review full report at Codecov.
|
|
Seems okay, but could you add some documentation in the README or whatever for how to properly use this and what the consequences of doing so are? |
fingolfin
force-pushed
the
mh/DISABLE_AMEND_COVERAGE_FROM_SRC
branch
from
6cc4d61
to
019121b
Compare
Closed
fingolfin
force-pushed
the
mh/DISABLE_AMEND_COVERAGE_FROM_SRC
branch
4 times, most recently
from
60c973e
to
7457973
Compare
|
Enabled this for testing, effect can be see on e.g. https://codecov.io/gh/JuliaCI/Coverage.jl/src/60c973e831cfa9f9e9da48ef07d3b8f35fbbd770/src/lcov.jl where function |
fingolfin
force-pushed
the
mh/DISABLE_AMEND_COVERAGE_FROM_SRC
branch
from
7457973
to
f5c0b8f
Compare
fingolfin
force-pushed
the
mh/DISABLE_AMEND_COVERAGE_FROM_SRC
branch
2 times, most recently
from
1d8b7cd
to
817c8b6
Compare
ararslan
reviewed
Mar 7, 2019
If the environment variable DISABLE_AMEND_COVERAGE_FROM_SRC is set to `yes`, do not call `amend_coverage_from_src!`. This is an optional mitigation for issue JuliaCI#187, and in general makes it easier to test the impact of amending the coverage data.
fingolfin
force-pushed
the
mh/DISABLE_AMEND_COVERAGE_FROM_SRC
branch
from
4611663
to
bf6a68b
Compare
ararslan
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the environment variable DISABLE_AMEND_COVERAGE_FROM_SRC is set to
yes, do not callamend_coverage_from_src!. This is an optional mitigation for issue #187, and in general makes it easier to test the impact of amending the coverage data.