Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: on every PR, run make -C deps USE_BINARYBUILDER=0 and make sure that the working directory is clean #264

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

This lets us catch checksum issues a little bit earlier, so that we don't have to wait for the scheduled from-source build.

@DilumAluthge
Copy link
Member Author

This will fail until JuliaLang/julia#47763 is merged.

@DilumAluthge
Copy link
Member Author

Idea: instead of doing this on each platform, just do make -f contrib/refresh-checksums.mk once on a single platform? Would that cover the checksums for all platforms?

@staticfloat
Copy link
Member

Yes, just rerun the check…. But IMO we shouldn’t run this on every job. That will hit upstream servers needlessly. We should only run it if a checksum file has been changed.

@DilumAluthge
Copy link
Member Author

We've talked a lot about having jobs that are only triggered when certain files are in the PR diff. I think this job could be a nice guinea pig for us to try that out?

I guess we basically need to get the PR diff, and then if anything under deps is modified, we launch this job, but otherwise, we don't launch it.

How do we get the PR diff? If we get it from the GitHub API, then we'll need to use a GitHub personal access token to avoid being rate-limited, and thus we'll need to make the "PR diff" job a signed job.

@giordano
Copy link
Contributor

giordano commented Dec 2, 2022

How do we get the PR diff?

#243 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants