Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up pdf CI using github actions #124

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Set up pdf CI using github actions #124

merged 4 commits into from
Aug 13, 2021

Conversation

johnnychen94
Copy link
Member

https://github.com/JuliaCN/documenter-latex-action is used to replace our old "tianjun2018/documenter-latex:latest" docker image

@johnnychen94 johnnychen94 mentioned this pull request Aug 13, 2021
Merged
4 tasks
@johnnychen94
Copy link
Member Author

johnnychen94 commented Aug 13, 2021 •
edited
Loading

Great! The new docker setup is working well. There are several things that need to be done here before merging:

  • Compiling pdf for every pull request will be time-consuming, thus I'll restrict our the docs CI trigger condition.
  • Similar to d1dc062, we also need to add a deploy action to our pdf branch
  • bring our GitLab ci back, which was temporarily commented out during set up Github Action CI #123
  • (maybe) document our CI workflow somewhere and clean up legacy files

@johnnychen94 johnnychen94 marked this pull request as ready for review August 13, 2021 11:10
@johnnychen94 johnnychen94 merged commit 1904352 into master Aug 13, 2021
@johnnychen94 johnnychen94 deleted the jc/pdf_ci branch August 13, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnnychen94