Skip to content

Commit

Permalink
Remove mention of Downloads.jl having threading issues (#594)
Browse files Browse the repository at this point in the history
* Remove mention of Downloads.jl having threading issues

The mentioned issues are closed:
- JuliaLang/Downloads.jl#110 (closed in Nov 2021
- JuliaLang/Downloads.jl#182 (closed in Apr 2022)

* Update src/utilities/downloads_backend.jl

Co-authored-by: arnaudh <[email protected]>

---------

Co-authored-by: mattBrzezinski <[email protected]>
Co-authored-by: mattBrzezinski <[email protected]>
  • Loading branch information
3 people authored Mar 21, 2023
1 parent f738b28 commit 183a579
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/utilities/downloads_backend.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ which is the `Downloads.Downloader` to use. If set to `nothing`, the default,
then a global downloader object will be used.
Downloads.jl tends to perform better under concurrent operation than HTTP.jl,
particularly with `@async` / `asyncmap`. As of March 2022, threading (e.g. `@spawn` or `@threads`) with Downloads.jl is broken on all releases of Julia ([Downloads.jl#110](https://github.com/JuliaLang/Downloads.jl/issues/110)), and there are still reported issues on the upcoming
1.7.3 and 1.8 releases ([Downloads.jl#182](https://github.com/JuliaLang/Downloads.jl/issues/182])).
particularly with `@async` / `asyncmap`. Note that threading (e.g. `@spawn` or `@threads`) with Downloads.jl is broken on Julia releases prior to 1.8 (https://github.com/JuliaLang/Downloads.jl/issues/182#issuecomment-1069269944).
"""
struct DownloadsBackend <: AWS.AbstractBackend
downloader::Union{Nothing,Downloads.Downloader}
Expand Down

0 comments on commit 183a579

Please sign in to comment.